From: Ingo Molnar <mingo@kernel.org>
To: Waiman Long <waiman.long@hpe.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Dave Hansen <dave.hansen@intel.com>,
"Chen, Tim C" <tim.c.chen@intel.com>,
Ingo Molnar <mingo@redhat.com>, Davidlohr Bueso <dbueso@suse.de>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Jason Low <jason.low2@hp.com>,
Michel Lespinasse <walken@google.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Waiman Long <waiman.long@hp.com>,
Al Viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: performance delta after VFS i_mutex=>i_rwsem conversion
Date: Wed, 8 Jun 2016 10:58:37 +0200 [thread overview]
Message-ID: <20160608085837.GA10792@gmail.com> (raw)
In-Reply-To: <5755E782.90800@hpe.com>
* Waiman Long <waiman.long@hpe.com> wrote:
> I do have a patchset that allow us to more accurately determine the state of
> the lock owner.
>
> locking/rwsem: Add reader-owned state to the owner field
> http://www.spinics.net/lists/kernel/msg2258572.html
>
> That should eliminate the performance gap between mutex and rwsem wrt
> spinning when only writers are present. I am hoping that that patchset can
> be queued for 4.8.
Yeah, so I actually had this series merged for testing last week, but a
complication with a prereq patch made me unmerge it. But I have no fundamental
objections, at all.
I also agree with Linus's general observation that we want to make
down_write()/up_write() match mutex performance characteristics.
I think kernel developers should fundamentally be able to switch between
mutex_lock()/unlock() and down_write()/up_write() and back, without noticing
any high level behavioral changes.
Any 'reader/writer mixing' artifacts are secondary concerns and we'll sort them
out as they happen.
Thanks,
Ingo
next prev parent reply other threads:[~2016-06-08 8:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 20:00 performance delta after VFS i_mutex=>i_rwsem conversion Dave Hansen
2016-06-06 20:46 ` Linus Torvalds
2016-06-06 21:13 ` Waiman Long
2016-06-06 21:20 ` Linus Torvalds
2016-06-07 3:22 ` Valdis.Kletnieks
2016-06-07 15:22 ` Waiman Long
2016-06-08 8:58 ` Ingo Molnar [this message]
2016-06-09 10:25 ` Ingo Molnar
2016-06-09 18:14 ` Dave Hansen
2016-06-09 20:10 ` Chen, Tim C
2016-06-06 21:15 ` Al Viro
2016-06-06 21:46 ` Linus Torvalds
2016-06-06 22:07 ` Al Viro
2016-06-06 23:50 ` Linus Torvalds
2016-06-06 23:59 ` Linus Torvalds
2016-06-07 0:29 ` Linus Torvalds
2016-06-07 0:40 ` Al Viro
2016-06-07 0:44 ` Al Viro
2016-06-07 0:58 ` Al Viro
2016-06-07 0:58 ` Linus Torvalds
2016-06-07 1:19 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608085837.GA10792@gmail.com \
--to=mingo@kernel.org \
--cc=dave.hansen@intel.com \
--cc=dbueso@suse.de \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tim.c.chen@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=waiman.long@hp.com \
--cc=waiman.long@hpe.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.