From: Wei Liu <wei.liu2@citrix.com>
To: Euan Harris <euan.harris@citrix.com>
Cc: kevin.tian@intel.com, Wei Liu <wei.liu2@citrix.com>,
jun.nakajima@intel.com, andrew.cooper3@citrix.com,
jbeulich@suse.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] nested vmx: Intercept guest rdmsr for MSR_IA32_VMX_VMFUNC
Date: Wed, 8 Jun 2016 12:54:20 +0100 [thread overview]
Message-ID: <20160608115420.GJ5714@citrix.com> (raw)
In-Reply-To: <1465294718-31626-1-git-send-email-euan.harris@citrix.com>
On Tue, Jun 07, 2016 at 10:18:38AM +0000, Euan Harris wrote:
> Guest reads of MSR_IA32_VMX_VMFUNC should be handled by
> the logic in vmx_msr_read_intercept(). Otherwise a guest
> can read the raw host value of this MSR, even if nested
> vmx is disabled.
>
> Signed-off-by: Euan Harris <euan.harris@citrix.com>
For 4.7:
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> xen/arch/x86/hvm/vmx/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 743b5a1..6c0721f 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -2624,7 +2624,7 @@ static int vmx_msr_read_intercept(unsigned int msr, uint64_t *msr_content)
> __vmread(GUEST_IA32_DEBUGCTL, msr_content);
> break;
> case IA32_FEATURE_CONTROL_MSR:
> - case MSR_IA32_VMX_BASIC...MSR_IA32_VMX_TRUE_ENTRY_CTLS:
> + case MSR_IA32_VMX_BASIC...MSR_IA32_VMX_VMFUNC:
> if ( !nvmx_msr_read_intercept(msr, msr_content) )
> goto gp_fault;
> break;
> --
> 1.7.10.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-08 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 10:18 [PATCH] nested vmx: Intercept guest rdmsr for MSR_IA32_VMX_VMFUNC Euan Harris
2016-06-07 10:35 ` Jan Beulich
2016-06-07 10:53 ` Euan Harris
2016-06-07 11:39 ` Andrew Cooper
2016-06-08 6:09 ` Tian, Kevin
2016-06-08 11:54 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608115420.GJ5714@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=euan.harris@citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.