From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 8 Jun 2016 16:09:46 +0200 From: Christoph Hellwig To: Sagi Grimberg Cc: Christoph Hellwig , keith.busch@intel.com, axboe@kernel.dk, linux-block@vger.kernel.org, ming.l@ssi.samsung.com, linux-nvme@lists.infradead.org, sagi@lightbits.io Subject: Re: [PATCH 11/11] nvme-fabrics: pass non-blocking flag to connect request allocation Message-ID: <20160608140946.GA1020@lst.de> References: <1465389066-19119-1-git-send-email-hch@lst.de> <1465389066-19119-12-git-send-email-hch@lst.de> <575823DD.8080000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <575823DD.8080000@gmail.com> List-ID: On Wed, Jun 08, 2016 at 04:55:41PM +0300, Sagi Grimberg wrote: > Looks fine, > > Reviewed-by: Sagi Grimberg > > Would be nice to reduce the number of arguments > passed to __nvme_submit_sync_cmd() at some point.. We're only adding them in our series.. But I agree that the number of arguments is a bit of a mess, but I couldn't really come up with something better. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 8 Jun 2016 16:09:46 +0200 Subject: [PATCH 11/11] nvme-fabrics: pass non-blocking flag to connect request allocation In-Reply-To: <575823DD.8080000@gmail.com> References: <1465389066-19119-1-git-send-email-hch@lst.de> <1465389066-19119-12-git-send-email-hch@lst.de> <575823DD.8080000@gmail.com> Message-ID: <20160608140946.GA1020@lst.de> On Wed, Jun 08, 2016@04:55:41PM +0300, Sagi Grimberg wrote: > Looks fine, > > Reviewed-by: Sagi Grimberg > > Would be nice to reduce the number of arguments > passed to __nvme_submit_sync_cmd() at some point.. We're only adding them in our series.. But I agree that the number of arguments is a bit of a mess, but I couldn't really come up with something better.