From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Wed, 8 Jun 2016 16:30:04 +0200 Subject: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. In-Reply-To: References: <1465388359-8070-1-git-send-email-daniel.vetter@ffwll.ch> <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> List-ID: Message-ID: <20160608143004.GE3363@phenom.ffwll.local> To: linux-snps-arc@lists.infradead.org On Wed, Jun 08, 2016@04:14:38PM +0200, Maarten Lankhorst wrote: > Op 08-06-16 om 14:18 schreef Daniel Vetter: > > The drm core has a nice ready-made helper for exactly the simple case > > where it should fire on the next vblank. > > > > Note that arming the vblank event in _begin is probably too early, and > > might easily result in the vblank firing too early, before the new set > > of planes are actually disabled. But that's kinda a minor issue > > compared to just outright hanging userspace. > > > > v2: Be more robust and either arm, when the CRTC is on, or just send > > the event out right away. > > > > Cc: Carlos Palminha > > Cc: Alexey Brodkin > > Cc: linux-snps-arc at lists.infradead.org > > Signed-off-by: Daniel Vetter > Wouldn't it be better to do this in atomic_flush then? I'm not going to fix up other people's drivers completely, just enough to hopefully not break them. If arc also blocks vblank interrupts with the go bit, then doing this in _begin is correct. Either way it needs hw-specific knowledge to asses whether it's correct, since doing the vblank event stuff in _flush is also racy without some prevention. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. Date: Wed, 8 Jun 2016 16:30:04 +0200 Message-ID: <20160608143004.GE3363@phenom.ffwll.local> References: <1465388359-8070-1-git-send-email-daniel.vetter@ffwll.ch> <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC3A06EA09 for ; Wed, 8 Jun 2016 14:30:09 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id m124so3445819wme.3 for ; Wed, 08 Jun 2016 07:30:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: Daniel Vetter , Alexey Brodkin , DRI Development , Carlos Palminha , Daniel Vetter , linux-snps-arc@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMDgsIDIwMTYgYXQgMDQ6MTQ6MzhQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDgtMDYtMTYgb20gMTQ6MTggc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gVGhlIGRybSBjb3JlIGhhcyBhIG5pY2UgcmVhZHktbWFkZSBoZWxwZXIgZm9yIGV4YWN0bHkg dGhlIHNpbXBsZSBjYXNlCj4gPiB3aGVyZSBpdCBzaG91bGQgZmlyZSBvbiB0aGUgbmV4dCB2Ymxh bmsuCj4gPgo+ID4gTm90ZSB0aGF0IGFybWluZyB0aGUgdmJsYW5rIGV2ZW50IGluIF9iZWdpbiBp cyBwcm9iYWJseSB0b28gZWFybHksIGFuZAo+ID4gbWlnaHQgZWFzaWx5IHJlc3VsdCBpbiB0aGUg dmJsYW5rIGZpcmluZyB0b28gZWFybHksIGJlZm9yZSB0aGUgbmV3IHNldAo+ID4gb2YgcGxhbmVz IGFyZSBhY3R1YWxseSBkaXNhYmxlZC4gQnV0IHRoYXQncyBraW5kYSBhIG1pbm9yIGlzc3VlCj4g PiBjb21wYXJlZCB0byBqdXN0IG91dHJpZ2h0IGhhbmdpbmcgdXNlcnNwYWNlLgo+ID4KPiA+IHYy OiBCZSBtb3JlIHJvYnVzdCBhbmQgZWl0aGVyIGFybSwgd2hlbiB0aGUgQ1JUQyBpcyBvbiwgb3Ig anVzdCBzZW5kCj4gPiB0aGUgZXZlbnQgb3V0IHJpZ2h0IGF3YXkuCj4gPgo+ID4gQ2M6IENhcmxv cyBQYWxtaW5oYSA8cGFsbWluaGFAc3lub3BzeXMuY29tPgo+ID4gQ2M6IEFsZXhleSBCcm9ka2lu IDxhYnJvZGtpbkBzeW5vcHN5cy5jb20+Cj4gPiBDYzogbGludXgtc25wcy1hcmNAbGlzdHMuaW5m cmFkZWFkLm9yZwo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBpbnRlbC5jb20+Cj4gV291bGRuJ3QgaXQgYmUgYmV0dGVyIHRvIGRvIHRoaXMgaW4gYXRvbWlj X2ZsdXNoIHRoZW4/CgpJJ20gbm90IGdvaW5nIHRvIGZpeCB1cCBvdGhlciBwZW9wbGUncyBkcml2 ZXJzIGNvbXBsZXRlbHksIGp1c3QgZW5vdWdoIHRvCmhvcGVmdWxseSBub3QgYnJlYWsgdGhlbS4g SWYgYXJjIGFsc28gYmxvY2tzIHZibGFuayBpbnRlcnJ1cHRzIHdpdGggdGhlIGdvCmJpdCwgdGhl biBkb2luZyB0aGlzIGluIF9iZWdpbiBpcyBjb3JyZWN0LiBFaXRoZXIgd2F5IGl0IG5lZWRzIGh3 LXNwZWNpZmljCmtub3dsZWRnZSB0byBhc3NlcyB3aGV0aGVyIGl0J3MgY29ycmVjdCwgc2luY2Ug ZG9pbmcgdGhlIHZibGFuayBldmVudApzdHVmZiBpbiBfZmx1c2ggaXMgYWxzbyByYWN5IHdpdGhv dXQgc29tZSBwcmV2ZW50aW9uLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK