From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1426343AbcFHOrJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jun 2016 10:47:09 -0400
Received: from mail-wm0-f46.google.com ([74.125.82.46]:34941 "EHLO
	mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1424457AbcFHOrG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jun 2016 10:47:06 -0400
Date: Wed, 8 Jun 2016 15:47:36 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Kyungmin Park <kyungmin.park@samsung.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Haojian Zhuang <haojian.zhuang@marvell.com>
Subject: Re: [PATCH 1/5] mfd: max8925-i2c: Make it explicitly non-modular
Message-ID: <20160608144736.GM14888@dell>
References: <1464914390-23520-1-git-send-email-paul.gortmaker@windriver.com>
 <1464914390-23520-2-git-send-email-paul.gortmaker@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1464914390-23520-2-git-send-email-paul.gortmaker@windriver.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 02 Jun 2016, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig: config MFD_MAX8925
> drivers/mfd/Kconfig:    bool "Maxim Semiconductor MAX8925 PMIC Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/mfd/max8925-i2c.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
> index 70443b161a5b..5c80aea3211f 100644
> --- a/drivers/mfd/max8925-i2c.c
> +++ b/drivers/mfd/max8925-i2c.c
> @@ -9,7 +9,7 @@
>   * published by the Free Software Foundation.
>   */
>  #include <linux/kernel.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/platform_device.h>
>  #include <linux/i2c.h>
>  #include <linux/mfd/max8925.h>
> @@ -133,7 +133,6 @@ static const struct i2c_device_id max8925_id_table[] = {
>  	{ "max8925", 0 },
>  	{ },
>  };
> -MODULE_DEVICE_TABLE(i2c, max8925_id_table);
>  
>  static int max8925_dt_init(struct device_node *np, struct device *dev,
>  			   struct max8925_platform_data *pdata)
> @@ -240,7 +239,6 @@ static const struct of_device_id max8925_dt_ids[] = {
>  	{ .compatible = "maxim,max8925", },
>  	{},
>  };
> -MODULE_DEVICE_TABLE(of, max8925_dt_ids);
>  
>  static struct i2c_driver max8925_driver = {
>  	.driver	= {
> @@ -264,13 +262,3 @@ static int __init max8925_i2c_init(void)
>  	return ret;
>  }
>  subsys_initcall(max8925_i2c_init);
> -
> -static void __exit max8925_i2c_exit(void)
> -{
> -	i2c_del_driver(&max8925_driver);
> -}
> -module_exit(max8925_i2c_exit);
> -
> -MODULE_DESCRIPTION("I2C Driver for Maxim 8925");
> -MODULE_AUTHOR("Haojian Zhuang <haojian.zhuang@marvell.com>");
> -MODULE_LICENSE("GPL");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog