Re: [PATCH for-4.7] Revert "libxl: No emulated disk driver for xvdX disk"

[Wei Liu <wei.liu2@citrix.com>]

On Wed, Jun 08, 2016 at 04:32:13PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH for-4.7] Revert "libxl: No emulated disk driver for xvdX disk""):
> > This reverts c0c099d157cc5bc942afef766cf141628a6380a1.
> > 
> > That commit causes regression on the semantics of our diskspec.
> > See [0] for more information.
> > 
> > [0] http://lists.xen.org/archives/html/xen-devel/2016-05/msg02876.html
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > Please review carefully about this patch. There are one commit that is
> > of interest: ef6cb76026628e26e3d1ae53c50ccde1c3c78b1b
> > 
> > I believe the reverting the snippet in question won't cause security
> > issue as described in XSA-142, because the code to create IDE disk still
> > checks if the disk is read-only.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> I think this is the right answer for 4.7.  In 4.8 we should do
> something like one of the proposals being discussed in this thread.
> 

Thanks.  And Anthony said on IRC this patch looked good to him.

I've queued this for committing to both unstable and 4.7.

Wei.

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel