From: Guenter Roeck <linux@roeck-us.net>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (tmp401) Add support for TI TMP461
Date: Wed, 8 Jun 2016 10:43:38 -0700 [thread overview]
Message-ID: <20160608174338.GC16615@roeck-us.net> (raw)
In-Reply-To: <57584E3D.8070501@ti.com>
On Wed, Jun 08, 2016 at 11:56:29AM -0500, Andrew F. Davis wrote:
[ ... ]
> >> static const u8 TMP432_TEMP_MSB_READ[4][3] = {
> >> @@ -149,6 +156,7 @@ static const struct i2c_device_id tmp401_id[] = {
> >> { "tmp431", tmp431 },
> >> { "tmp432", tmp432 },
> >> { "tmp435", tmp435 },
> >> + { "tmp461", tmp461 },
> >
> > Please also provide code in the detect function to auto-detect the chip.
> >
>
> It looks like the ID reg has been removed (at least from the datasheet)
> so I'm not sure there is any good way to ID this part.
>
Outch :-(
Well, nothing we can do about that. Even if the register was there and provides
a value, it would be undocumented and thus unreliable and unusable. Too bad.
Thanks,
Guenter
prev parent reply other threads:[~2016-06-08 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 16:27 [PATCH] hwmon: (tmp401) Add support for TI TMP461 Andrew F. Davis
2016-06-04 4:41 ` Guenter Roeck
2016-06-08 16:56 ` Andrew F. Davis
2016-06-08 17:43 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608174338.GC16615@roeck-us.net \
--to=linux@roeck-us.net \
--cc=afd@ti.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.