From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/3] librte_eal: Import FreeBSD sys/tree.h into librte_eal/common Date: Wed, 8 Jun 2016 17:58:48 -0700 Message-ID: <20160608175848.28bff0d1@xeon-e3> References: <1465433634-6667-1-git-send-email-nikita@elyzion.net> <1465433634-6667-3-git-send-email-nikita@elyzion.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Nikita Kozlov To: Nikita Kozlov Return-path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 072E9567B for ; Thu, 9 Jun 2016 02:58:38 +0200 (CEST) Received: by mail-pf0-f176.google.com with SMTP id c2so7687073pfa.2 for ; Wed, 08 Jun 2016 17:58:37 -0700 (PDT) In-Reply-To: <1465433634-6667-3-git-send-email-nikita@elyzion.net> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 9 Jun 2016 02:53:53 +0200 Nikita Kozlov wrote: > This structure is used inside the rte_lpm6 lib for storing added rules. > It's imported from FreeBSD-10.3 from /usr/include/sys/tree.h, another > solution could have been to use on Linux the version from libbsd but it > would create an external dependency. > > Signed-off-by: Nikita Kozlov Using Red-black tree is a good idea, and we have been doing it for a while both on v4 and v6. But this is not the way to handle it. Please don't copy a header file which is available already on both BSD and Linux.