From: Brian Norris <briannorris@chromium.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-kernel@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM
Date: Wed, 8 Jun 2016 13:00:38 -0700 [thread overview]
Message-ID: <20160608200038.GA136963@google.com> (raw)
In-Reply-To: <57586956.2070008@linaro.org>
On Wed, Jun 08, 2016 at 07:52:06PM +0100, Srinivas Kandagatla wrote:
> On 08/06/16 17:40, Brian Norris wrote:
> >On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote:
> >>With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM
> >>it returns char *. Let's make that consistent. Also drop the
> >>incorrect/inconsistent comment about char * above the nvmem_cell_read()
> >>definition.
> >>
> >>drivers/thermal/mtk_thermal.c is already working around this by casting
> >>to (u32 *).
> >>
> >>Signed-off-by: Brian Norris <briannorris@chromium.org>
> >
> >Seems Guenter submitted the same thing a week ago, with no response:
>
> This patch has been already sent to Greg few days back with my sign
> off http://permalink.gmane.org/gmane.linux.kernel/2233276
Ah, didn't notice that either. Anyway, doesn't seem to show up in
linux-next.
Brian
prev parent reply other threads:[~2016-06-08 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 16:26 [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM Brian Norris
2016-06-08 16:40 ` Brian Norris
2016-06-08 17:40 ` Guenter Roeck
2016-06-08 18:52 ` Srinivas Kandagatla
2016-06-08 20:00 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608200038.GA136963@google.com \
--to=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.