From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3 08/20] vhost: introduce new API to export
	numa node
Date: Thu, 9 Jun 2016 12:45:00 +0800
Message-ID: <20160609044500.GK10038@yliu-dev.sh.intel.com>
References: <1463117111-27050-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1465271530-27878-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1465271530-27878-9-git-send-email-yuanhan.liu@linux.intel.com>
 <CAGSMBPOkB+1qrzS32yzFGeO_UKkbJ=WPbR3JGTWhtXxQ1DoBXg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, "huawei.xie" <huawei.xie@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Panu Matilainen <pmatilai@redhat.com>,
 Traynor Kevin <kevin.traynor@intel.com>, Tetsuya Mukawa <mukawa@igel.co.jp>
To: Rich Lane <rich.lane@bigswitch.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id BFE586A68
 for <dev@dpdk.org>; Thu,  9 Jun 2016 06:43:47 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CAGSMBPOkB+1qrzS32yzFGeO_UKkbJ=WPbR3JGTWhtXxQ1DoBXg@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 08, 2016 at 02:51:33PM -0700, Rich Lane wrote:
> On Mon, Jun 6, 2016 at 8:51 PM, Yuanhan Liu <yuanhan.liu@linux.intel.co=
m>
> wrote:
>=20
>     @@ -248,14 +248,9 @@ new_device(struct virtio_net *dev)
>     =A0 =A0 =A0 =A0 internal =3D eth_dev->data->dev_private;
>=20
>     =A0#ifdef RTE_LIBRTE_VHOST_NUMA
>     -=A0 =A0 =A0 =A0ret=A0 =3D get_mempolicy(&newnode, NULL, 0, dev,
>     -=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0MPOL_F_NODE | MPOL_=
F_ADDR);
>     -=A0 =A0 =A0 =A0if (ret < 0) {
>     -=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0RTE_LOG(ERR, PMD, "Unknown numa nod=
e\n");
>     -=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return -1;
>     -=A0 =A0 =A0 =A0}
>     -
>     -=A0 =A0 =A0 =A0eth_dev->data->numa_node =3D newnode;
>     +=A0 =A0 =A0 =A0newnode =3D rte_vhost_get_numa_node(dev->vid);
>     +=A0 =A0 =A0 =A0if (newnode > 0)
>=20
>=20
> Should be "newnode >=3D 0".=A0

Nice catch! Thanks.

	--yliu