All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] events/uprobes: move smp_read_barrier_depends() where needed
Date: Fri, 10 Jun 2016 14:59:04 +0200	[thread overview]
Message-ID: <20160610125904.GA8203@redhat.com> (raw)
In-Reply-To: <CAPZ9YJaxdqpCh9DyD7ubrTEhCL9jEdMzNN6zJHsOPYGN5NNPXg@mail.gmail.com>

On 06/10, Andrea Parri wrote:
>
> On Fri, Jun 10, 2016 at 9:03 AM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> > On 06/09, Andrea Parri wrote:
> > >
> > > There is no need to use the barrier if there is no dereference/
> > > memory access; move it where needed (currently, affecting only
> > > Alpha).
> >
> > OK, although area == NULL is unlikely case,
> >
> > > While touching this, also make the reads _ONCE().
> >
> > Why? both xol_area/vaddr can't change.
> >
>
> This is to ensure current (and future) compiler transformations
> won't optimize out or reorder the reads (do not ask me how ...,
> IAC the volatile casts will prevent this to happen).
>
> AFAICT, xol_area can be "== NULL" and "!= NULL" ...

Yes, but it can't change if it is not NULL. So we do not care if gcc
reads xol_area/vaddr twice or reorderes this with other LOADs.

Oleg.

      parent reply	other threads:[~2016-06-10 12:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-09 18:18 [PATCH] events/uprobes: move smp_read_barrier_depends() where needed Andrea Parri
2016-06-10  7:03 ` Oleg Nesterov
2016-06-10 12:26   ` Oleg Nesterov
     [not found]     ` <CAPZ9YJY_6mB797YRG4=byTbz6WTH91GZjba9zDQhZ+J0C-khSg@mail.gmail.com>
2016-06-10 13:07       ` Oleg Nesterov
2016-06-10 14:39         ` Oleg Nesterov
     [not found]           ` <CAPZ9YJYPynX2vGgFarhiyUN0GF--h6r2kbhJ4pRt2NMY1qCODg@mail.gmail.com>
2016-06-10 19:36             ` Oleg Nesterov
     [not found]   ` <CAPZ9YJaxdqpCh9DyD7ubrTEhCL9jEdMzNN6zJHsOPYGN5NNPXg@mail.gmail.com>
2016-06-10 12:59     ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160610125904.GA8203@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parri.andrea@gmail.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.