Re: [PATCH v2] pwm: lpss: fix base_unit calculation for PWM frequency

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Wed, Jun 01, 2016 at 03:31:12PM +0100, Dan O'Donovan wrote:
> The base_unit calculation applies an offset of 0x2 which adds
> significant error for lower frequencies and doesn't appear to be
> warranted - rounding the division result gives a correct value.
> 
> Also, the upper limit check for base_unit is off-by-one; the upper
> nibble of base_unit is invalid if >=128 according to the Table 88
> in the Z8000 Processor Series Datasheet Volume 1 (Rev. 2).
> 
> Verified on UP Board (Cherry Trail) and Minnowboard Max (Bay Trail).
> 
> Signed-off-by: Dan O'Donovan <dan@emutex.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> v2:
>  * fixed error in a code comment regarding base_unit, spotted by Mika
> 
>  drivers/pwm/pwm-lpss.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]