From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Fri, 10 Jun 2016 16:54:02 +0200 Subject: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. In-Reply-To: <20160610141927.GA3363@phenom.ffwll.local> References: <20160609122631.GO3363@phenom.ffwll.local> <1465476465.3203.66.camel@synopsys.com> <20160609132327.GQ3363@phenom.ffwll.local> <1465478829.3203.68.camel@synopsys.com> <20160609135222.GS3363@phenom.ffwll.local> <1465482496.3203.73.camel@synopsys.com> <1465564954.2942.40.camel@synopsys.com> <20160610141927.GA3363@phenom.ffwll.local> List-ID: Message-ID: <20160610145402.GG3363@phenom.ffwll.local> To: linux-snps-arc@lists.infradead.org On Fri, Jun 10, 2016@04:19:27PM +0200, Daniel Vetter wrote: > On Fri, Jun 10, 2016@01:23:22PM +0000, Alexey Brodkin wrote: > > Hi Daniel, > > > > On Thu, 2016-06-09@16:37 +0200, Daniel Vetter wrote: > > > On Thu, Jun 9, 2016@4:31 PM, Daniel Vetter wrote: > > > > > > > > On Thu, Jun 9, 2016 at 4:29 PM, Alexey Brodkin > > > > wrote: > > > > > > > > > > Hi Daniel, > > > > > > > > > > On Thu, 2016-06-09@15:52 +0200, Daniel Vetter wrote: > > > > > > > > > > > > > > > > > > The fake implementation is fundamentally racy, and I don't want to write > > > > > > helpers which can't be used correctly. Anyway I think without this patch > > > > > > (or something similar) arcpgu will stall badly with the new nonblocking > > > > > > helpers, because arcpgu didn't bother at all to implement nonblocking. Can > > > > > > you pls ack this, or even better, test the entire patch series? The > > > > > > helpers themselves should work, but in all 5 drivers tested thus far they > > > > > > discovered some bugs. > > > > > Sure I will happily test this series. > > > > > The only question then is what should I use as a proper base? > > > > It should apply on drm-next from Dave. > > > > > > And indeed it won't work at all because arcpgu doesn't call > > > drm_crtc_handle_vblank anywhere. So you need to add your patch to > > > enable vblank interrupts somewhere. Note that as long as you leave > > > max_vblank_counter as 0, the only bits you need is drm_vblank_init and > > > drm_crtc_handle_vblanke() from the irq handler. > > > > So is there any sense in testing that series if vblank interrupt is not yet > > supported (I'm looking forward to implementing it sometime soon but definitely > > I'm not there yet)? > > Well, it might break your driver, so yes. I'm ofc happy to help unbreak it, > but without someone who tests there's not much I can do, so will just go > ahead and apply and hope it works. Ok I went ahead and pushed a slight revised version of that patch which just unconditionally sends out the event. That's not correct, but at least that way the nonblocking changes won't totally break arcpgu and I can move ahead with those. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. Date: Fri, 10 Jun 2016 16:54:02 +0200 Message-ID: <20160610145402.GG3363@phenom.ffwll.local> References: <20160609122631.GO3363@phenom.ffwll.local> <1465476465.3203.66.camel@synopsys.com> <20160609132327.GQ3363@phenom.ffwll.local> <1465478829.3203.68.camel@synopsys.com> <20160609135222.GS3363@phenom.ffwll.local> <1465482496.3203.73.camel@synopsys.com> <1465564954.2942.40.camel@synopsys.com> <20160610141927.GA3363@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 492146ED88 for ; Fri, 10 Jun 2016 14:54:07 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id r5so18546063wmr.0 for ; Fri, 10 Jun 2016 07:54:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160610141927.GA3363@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexey Brodkin Cc: "daniel.vetter@intel.com" , "linux-snps-arc@lists.infradead.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMTAsIDIwMTYgYXQgMDQ6MTk6MjdQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIEp1biAxMCwgMjAxNiBhdCAwMToyMzoyMlBNICswMDAwLCBBbGV4ZXkg QnJvZGtpbiB3cm90ZToKPiA+IEhpIERhbmllbCwKPiA+IAo+ID4gT24gVGh1LCAyMDE2LTA2LTA5 IGF0IDE2OjM3ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBUaHUsIEp1biA5 LCAyMDE2IGF0IDQ6MzEgUE0sIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6 Cj4gPiA+ID4gCj4gPiA+ID4gT24gVGh1LCBKdW4gOSwgMjAxNiBhdCA0OjI5IFBNLCBBbGV4ZXkg QnJvZGtpbgo+ID4gPiA+IDxBbGV4ZXkuQnJvZGtpbkBzeW5vcHN5cy5jb20+IHdyb3RlOgo+ID4g PiA+ID4gCj4gPiA+ID4gPiBIaSBEYW5pZWwsCj4gPiA+ID4gPiAKPiA+ID4gPiA+IE9uIFRodSwg MjAxNi0wNi0wOSBhdCAxNTo1MiArMDIwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ID4gPiA+ ID4gCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBUaGUgZmFrZSBpbXBsZW1lbnRhdGlvbiBpcyBm dW5kYW1lbnRhbGx5IHJhY3ksIGFuZCBJIGRvbid0IHdhbnQgdG8gd3JpdGUKPiA+ID4gPiA+ID4g aGVscGVycyB3aGljaCBjYW4ndCBiZSB1c2VkIGNvcnJlY3RseS4gQW55d2F5IEkgdGhpbmsgd2l0 aG91dCB0aGlzIHBhdGNoCj4gPiA+ID4gPiA+IChvciBzb21ldGhpbmcgc2ltaWxhcikgYXJjcGd1 IHdpbGwgc3RhbGwgYmFkbHkgd2l0aCB0aGUgbmV3IG5vbmJsb2NraW5nCj4gPiA+ID4gPiA+IGhl bHBlcnMsIGJlY2F1c2UgYXJjcGd1IGRpZG4ndCBib3RoZXIgYXQgYWxsIHRvIGltcGxlbWVudCBu b25ibG9ja2luZy4gQ2FuCj4gPiA+ID4gPiA+IHlvdSBwbHMgYWNrIHRoaXMsIG9yIGV2ZW4gYmV0 dGVyLCB0ZXN0IHRoZSBlbnRpcmUgcGF0Y2ggc2VyaWVzPyBUaGUKPiA+ID4gPiA+ID4gaGVscGVy cyB0aGVtc2VsdmVzIHNob3VsZCB3b3JrLCBidXQgaW4gYWxsIDUgZHJpdmVycyB0ZXN0ZWQgdGh1 cyBmYXIgdGhleQo+ID4gPiA+ID4gPiBkaXNjb3ZlcmVkIHNvbWUgYnVncy4KPiA+ID4gPiA+IFN1 cmUgSSB3aWxsIGhhcHBpbHkgdGVzdCB0aGlzIHNlcmllcy4KPiA+ID4gPiA+IFRoZSBvbmx5IHF1 ZXN0aW9uIHRoZW4gaXMgd2hhdCBzaG91bGQgSSB1c2UgYXMgYSBwcm9wZXIgYmFzZT8KPiA+ID4g PiBJdCBzaG91bGQgYXBwbHkgb24gZHJtLW5leHQgZnJvbSBEYXZlLgo+ID4gPgo+ID4gPiBBbmQg aW5kZWVkIGl0IHdvbid0IHdvcmsgYXQgYWxsIGJlY2F1c2UgYXJjcGd1IGRvZXNuJ3QgY2FsbAo+ ID4gPiBkcm1fY3J0Y19oYW5kbGVfdmJsYW5rIGFueXdoZXJlLiBTbyB5b3UgbmVlZCB0byBhZGQg eW91ciBwYXRjaCB0bwo+ID4gPiBlbmFibGUgdmJsYW5rIGludGVycnVwdHMgc29tZXdoZXJlLiBO b3RlIHRoYXQgYXMgbG9uZyBhcyB5b3UgbGVhdmUKPiA+ID4gbWF4X3ZibGFua19jb3VudGVyIGFz IDAsIHRoZSBvbmx5IGJpdHMgeW91IG5lZWQgaXMgZHJtX3ZibGFua19pbml0IGFuZAo+ID4gPiBk cm1fY3J0Y19oYW5kbGVfdmJsYW5rZSgpIGZyb20gdGhlIGlycSBoYW5kbGVyLgo+ID4gCj4gPiBT byBpcyB0aGVyZSBhbnkgc2Vuc2UgaW4gdGVzdGluZyB0aGF0IHNlcmllcyBpZiB2YmxhbmsgaW50 ZXJydXB0IGlzIG5vdCB5ZXQKPiA+IHN1cHBvcnRlZCAoSSdtIGxvb2tpbmcgZm9yd2FyZCB0byBp bXBsZW1lbnRpbmcgaXQgc29tZXRpbWUgc29vbiBidXQgZGVmaW5pdGVseQo+ID4gSSdtIG5vdCB0 aGVyZSB5ZXQpPwo+IAo+IFdlbGwsIGl0IG1pZ2h0IGJyZWFrIHlvdXIgZHJpdmVyLCBzbyB5ZXMu IEknbSBvZmMgaGFwcHkgdG8gaGVscCB1bmJyZWFrIGl0LAo+IGJ1dCB3aXRob3V0IHNvbWVvbmUg d2hvIHRlc3RzIHRoZXJlJ3Mgbm90IG11Y2ggSSBjYW4gZG8sIHNvIHdpbGwganVzdCBnbwo+IGFo ZWFkIGFuZCBhcHBseSBhbmQgaG9wZSBpdCB3b3Jrcy4KCk9rIEkgd2VudCBhaGVhZCBhbmQgcHVz aGVkIGEgc2xpZ2h0IHJldmlzZWQgdmVyc2lvbiBvZiB0aGF0IHBhdGNoIHdoaWNoCmp1c3QgdW5j b25kaXRpb25hbGx5IHNlbmRzIG91dCB0aGUgZXZlbnQuIFRoYXQncyBub3QgY29ycmVjdCwgYnV0 IGF0IGxlYXN0CnRoYXQgd2F5IHRoZSBub25ibG9ja2luZyBjaGFuZ2VzIHdvbid0IHRvdGFsbHkg YnJlYWsgYXJjcGd1IGFuZCBJIGNhbiBtb3ZlCmFoZWFkIHdpdGggdGhvc2UuCi1EYW5pZWwKLS0g CkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6 Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=