From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 06/20] drm: i915: Rely on the default ->best_encoder() behavior where appropriate Date: Fri, 10 Jun 2016 18:41:52 +0200 Message-ID: <20160610164152.GO3363@phenom.ffwll.local> References: <1465300095-16971-1-git-send-email-boris.brezillon@free-electrons.com> <1465300095-16971-7-git-send-email-boris.brezillon@free-electrons.com> <20160610152412.GL3363@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160610152412.GL3363@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Boris Brezillon , David Airlie , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Alexey Brodkin , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Stefan Agner , Alison Wang , Matthias Brugger , Rob Clark , Laurent Pinchart , Mark Yao , Heiko Stuebner List-Id: linux-samsung-soc@vger.kernel.org T24gRnJpLCBKdW4gMTAsIDIwMTYgYXQgMDU6MjQ6MTJQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEp1biAwNywgMjAxNiBhdCAwMTo0ODowMVBNICswMjAwLCBCb3JpcyBC cmV6aWxsb24gd3JvdGU6Cj4gPiBGb3IgYWxsIG91dHB1dHMgZXhjZXB0IGRwX21zdCwgd2UgaGF2 ZSBhIDE6MSByZWxhdGlvbnNoaXAgYmV0d2Vlbgo+ID4gY29ubmVjdG9ycyBhbmQgZW5jb2RlcnMg YW5kIHRoZSBkcml2ZXIgaXMgcmVseWluZyBvbiB0aGUgYXRvbWljIGhlbHBlcnM6Cj4gPiB3ZSBj YW4gZHJvcCB0aGUgY3VzdG9tIC0+YmVzdF9lbmNvZGVyKCkgaW1wbGVtZW50YXRpb24gYW5kIGxl dCB0aGUgY29yZQo+ID4gY2FsbCBkcm1fYXRvbWljX2hlbHBlcl9iZXN0X2VuY29kZXIoKSBmb3Ig dXMuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemls bG9uQGZyZWUtZWxlY3Ryb25zLmNvbT4KPiAKPiBZb3UgY2FuIGFsc28gZHJvcCB0aGUgYmVzdF9l bmNvZGVyIGZyb20gaW50ZWxfZHBfbXN0LCB3ZSBvbmx5IG5lZWQgdGhlCj4gYXRvbWljX2Jlc3Rf ZW5jb2Rlci4gVGhlIGJlc3RfZW5jb2RlciB0aGVyZSB3YXMgbmVlZGVkIHRvIGhlbHAgb3V0IHRo ZQo+IGZiZGV2IGVtdWxhdGlvbi4gQ2FyZSB0byByZXNwaW4/CgpCb3JpcyBwb2ludGVkIG91dCBv biBpcmMgdGhhdCB0aGlzIHdvbid0IHdvcmsgZm9yIHRoZSBmYmRldiBzdHVmZiBzaW5jZQp0aGF0 IGhhcyBhIFdBUk5fT04gaWYgdGhlcmVzIG1vcmUgdGhhbiAxIHBvc3NpYmxlIGVuY29kZXIuIEFw cGxpZWQgdGhpcwpvbmUgaGVyZSBpbnN0ZWFkLgoKVGhhbmtzLCBEYW5pZWwKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 10 Jun 2016 18:41:52 +0200 From: Daniel Vetter To: Boris Brezillon , David Airlie , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Alexey Brodkin , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Stefan Agner , Alison Wang , Matthias Brugger , Rob Clark , Laurent Pinchart , Mark Yao , Heiko Stuebner , Benjamin Gaignard , Vincent Abriou , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , Stephen Warren , Alexandre Courbot , Eric Anholt , Gerd Hoffmann , linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 06/20] drm: i915: Rely on the default ->best_encoder() behavior where appropriate Message-ID: <20160610164152.GO3363@phenom.ffwll.local> References: <1465300095-16971-1-git-send-email-boris.brezillon@free-electrons.com> <1465300095-16971-7-git-send-email-boris.brezillon@free-electrons.com> <20160610152412.GL3363@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160610152412.GL3363@phenom.ffwll.local> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Jun 10, 2016 at 05:24:12PM +0200, Daniel Vetter wrote: > On Tue, Jun 07, 2016 at 01:48:01PM +0200, Boris Brezillon wrote: > > For all outputs except dp_mst, we have a 1:1 relationship between > > connectors and encoders and the driver is relying on the atomic helpers: > > we can drop the custom ->best_encoder() implementation and let the core > > call drm_atomic_helper_best_encoder() for us. > > > > Signed-off-by: Boris Brezillon > > You can also drop the best_encoder from intel_dp_mst, we only need the > atomic_best_encoder. The best_encoder there was needed to help out the > fbdev emulation. Care to respin? Boris pointed out on irc that this won't work for the fbdev stuff since that has a WARN_ON if theres more than 1 possible encoder. Applied this one here instead. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Fri, 10 Jun 2016 18:41:52 +0200 Subject: [PATCH v2 06/20] drm: i915: Rely on the default ->best_encoder() behavior where appropriate In-Reply-To: <20160610152412.GL3363@phenom.ffwll.local> References: <1465300095-16971-1-git-send-email-boris.brezillon@free-electrons.com> <1465300095-16971-7-git-send-email-boris.brezillon@free-electrons.com> <20160610152412.GL3363@phenom.ffwll.local> Message-ID: <20160610164152.GO3363@phenom.ffwll.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jun 10, 2016 at 05:24:12PM +0200, Daniel Vetter wrote: > On Tue, Jun 07, 2016 at 01:48:01PM +0200, Boris Brezillon wrote: > > For all outputs except dp_mst, we have a 1:1 relationship between > > connectors and encoders and the driver is relying on the atomic helpers: > > we can drop the custom ->best_encoder() implementation and let the core > > call drm_atomic_helper_best_encoder() for us. > > > > Signed-off-by: Boris Brezillon > > You can also drop the best_encoder from intel_dp_mst, we only need the > atomic_best_encoder. The best_encoder there was needed to help out the > fbdev emulation. Care to respin? Boris pointed out on irc that this won't work for the fbdev stuff since that has a WARN_ON if theres more than 1 possible encoder. Applied this one here instead. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch