From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: host-generic: select IRQ_DOMAIN
Date: Fri, 10 Jun 2016 19:00:16 -0500 [thread overview]
Message-ID: <20160611000015.GC16462@localhost> (raw)
In-Reply-To: <1463581000-983246-1-git-send-email-arnd@arndb.de>
On Wed, May 18, 2016 at 04:15:53PM +0200, Arnd Bergmann wrote:
> The generic PCI host controller calls of_irq_parse_and_map_pci
> in its IRQ fixup, but that function is only available when
> CONFIG_IRQ_DOMAIN is set:
>
> drivers/pci/built-in.o: In function `pci_host_common_probe':
> drivers/pci/host/pci-host-common.c:181: undefined reference to `of_irq_parse_and_map_pci'
>
> There is no downside in enabling the domains here, so let's
> use a Kconfig select statement to ensure it's always available
> to this driver.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to pci/host-generic for v4.8, thanks, Arnd.
> ---
> drivers/pci/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 66329b932e29..64734ba070a2 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -87,6 +87,7 @@ config PCI_HOST_GENERIC
> bool "Generic PCI host controller"
> depends on (ARM || ARM64) && OF
> select PCI_HOST_COMMON
> + select IRQ_DOMAIN
> help
> Say Y here if you want to support a simple generic PCI host
> controller, such as the one emulated by kvmtool.
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-06-11 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 14:15 [PATCH] PCI: host-generic: select IRQ_DOMAIN Arnd Bergmann
2016-06-11 0:00 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160611000015.GC16462@localhost \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.