From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: fw@strlen.de, netdev@vger.kernel.org
Subject: Re: [PATCH v2 -next] sched: remove NET_XMIT_POLICED
Date: Sun, 12 Jun 2016 00:57:06 +0200 [thread overview]
Message-ID: <20160611225706.GA16798@breakpoint.cc> (raw)
In-Reply-To: <20160611.155407.1424553523659683009.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Sat, 11 Jun 2016 12:46:04 +0200
>
> > sch_atm returns this when TC_ACT_SHOT classification occurs.
> >
> > But all other schedulers that use tc_classify
> > (htb, hfsc, drr, fq_codel ...) return NET_XMIT_SUCCESS | __BYPASS
> > in this case so just do that in atm.
>
> Yes, but it's been like this for two decades.
>
> One of the points of my reply to the previous version of this
> patch is that indeed it is explicitly returned, intentionally.
But nothing evaluates it?
Only exception is pktgen which treats it line _CN and _DROP...
[ But I dont mind if you'd rather leave it alone, I just find it
silly we have a NET_XMIT_ that has no clear meaning or use ]
next prev parent reply other threads:[~2016-06-11 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 10:46 [PATCH v2 -next] sched: remove NET_XMIT_POLICED Florian Westphal
2016-06-11 22:54 ` David Miller
2016-06-11 22:57 ` Florian Westphal [this message]
2016-06-12 0:14 ` Cong Wang
2016-06-13 2:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160611225706.GA16798@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.