From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932579AbcFLLJs (ORCPT <rfc822;w@1wt.eu>);
	Sun, 12 Jun 2016 07:09:48 -0400
Received: from mailout3.hostsharing.net ([176.9.242.54]:51580 "EHLO
	mailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932502AbcFLLJq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 12 Jun 2016 07:09:46 -0400
Date: Sun, 12 Jun 2016 13:13:38 +0200
From: Lukas Wunner <lukas@wunner.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Yinghai Lu <yinghai@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, cmilsted@redhat.com,
        Rafa?? Mi??ecki <zajec5@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Matthew Garrett <mjg59@srcf.ucam.org>, m@bues.ch,
        "linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>,
        Doug Ledford <dledford@redhat.com>,
        Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple
 AirPort card
Message-ID: <20160612111338.GA20623@wunner.de>
References: <20160609064803.GA10996@gmail.com>
 <20160609110424.GA19470@wunner.de>
 <CAE9FiQVN25PC_jMG1cDqwrDc_X2gMFwVMnLcgyiMST6_868Aaw@mail.gmail.com>
 <20160609202036.GA19638@wunner.de>
 <CAE9FiQVSxSmhYQhoccDYEhvbRrb0DPnPvZBw9D257OGePGRcAA@mail.gmail.com>
 <20160610115845.GA27253@gmail.com>
 <20160610121628.GA19823@wunner.de>
 <20160610125957.GA30577@gmail.com>
 <20160610135904.GA19958@wunner.de>
 <20160610200802.GB7843@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160610200802.GB7843@localhost>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 10, 2016 at 03:08:02PM -0500, Bjorn Helgaas wrote:
> On Fri, Jun 10, 2016 at 03:59:04PM +0200, Lukas Wunner wrote:
> > On Fri, Jun 10, 2016 at 02:59:57PM +0200, Ingo Molnar wrote:
> > > So I'd lean towards lower complexity, but since this is essentially
> > > PCI code I'd like to defer to Bjorn on that detail.
> 
> Since you asked my opinion, here it is, but it's probably more than
> you wanted :)

That is one sublime review. Thanks a lot.

I've just posted v2, taking into account all of Bjorn's suggestions:
https://lkml.org/lkml/2016/6/12/65

@Ingo Molnar: I noticed that you've removed the line breaks in
read/write_pci_config_16(). I've carried that change over to v2
even though it exceeds 80 chars/line and thus doesn't seem to
comply with Documentation/CodingStyle, chapter 2.

Please note that the stable designation in patch [3/3] needs to be
amended with the sha1 of the two preceding patches after they have
been merged.

Thanks again & best regards,

Lukas