From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.85.209 with SMTP id j200csp1066501lfb; Mon, 13 Jun 2016 00:48:32 -0700 (PDT) X-Received: by 10.237.56.225 with SMTP id k88mr12466519qte.86.1465804112515; Mon, 13 Jun 2016 00:48:32 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y78si7503011qha.38.2016.06.13.00.48.32 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 13 Jun 2016 00:48:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:54248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCMbo-0001QO-1H for alex.bennee@linaro.org; Mon, 13 Jun 2016 03:48:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCMaj-0000Yv-JG for qemu-devel@nongnu.org; Mon, 13 Jun 2016 03:47:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCMai-0002hm-Nq for qemu-devel@nongnu.org; Mon, 13 Jun 2016 03:47:25 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:40044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCMai-0002hc-IX; Mon, 13 Jun 2016 03:47:24 -0400 Received: from ohm.aurel32.net ([2001:bc8:30d7:111::1000]) by hall.aurel32.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bCMaL-0006iQ-TO; Mon, 13 Jun 2016 09:47:01 +0200 Received: from aurel32 by ohm.aurel32.net with local (Exim 4.87) (envelope-from ) id 1bCLuA-0004ZQ-Ef; Mon, 13 Jun 2016 09:03:26 +0200 Date: Mon, 13 Jun 2016 09:03:26 +0200 From: Aurelien Jarno To: Sergey Sorokin Message-ID: <20160613070325.GA16232@aurel32.net> References: <1465575999-3594234-1-git-send-email-afarallax@yandex.ru> <1465575999-3594234-2-git-send-email-afarallax@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465575999-3594234-2-git-send-email-afarallax@yandex.ru> User-Agent: Mutt/1.6.0 (2016-04-01) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:bc8:30d7:100::1 Subject: Re: [Qemu-devel] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Guan Xuetao , Eduardo Habkost , Peter Crosthwaite , Jia Liu , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Bastian Koppelmann , Alexander Graf , Blue Swirl , Max Filippov , Michael Walle , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, "Edgar E. Iglesias" , Paolo Bonzini , David Gibson , Leon Alrae , Richard Henderson Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: uw1ER1JlLRx/ On 2016-06-10 19:26, Sergey Sorokin wrote: > There are functions cpu_unaligned_access() and do_unaligned_access() that > are called with access type and mmu index arguments. But these arguments > are named 'is_write' and 'is_user' in their declarations. > The patch fixes the names to avoid a confusion. Unless I missed something, it seems that the is_user/mmu_idx argument is never used. Should we maybe just drop it? Otherwise it looks fine. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCMaj-0000Yv-JG for qemu-devel@nongnu.org; Mon, 13 Jun 2016 03:47:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCMai-0002hm-Nq for qemu-devel@nongnu.org; Mon, 13 Jun 2016 03:47:25 -0400 Date: Mon, 13 Jun 2016 09:03:26 +0200 From: Aurelien Jarno Message-ID: <20160613070325.GA16232@aurel32.net> References: <1465575999-3594234-1-git-send-email-afarallax@yandex.ru> <1465575999-3594234-2-git-send-email-afarallax@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465575999-3594234-2-git-send-email-afarallax@yandex.ru> Subject: Re: [Qemu-devel] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Sorokin Cc: qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Peter Maydell , "Edgar E. Iglesias" , Eduardo Habkost , Michael Walle , Leon Alrae , Anthony Green , Jia Liu , David Gibson , Alexander Graf , Blue Swirl , Mark Cave-Ayland , Bastian Koppelmann , Guan Xuetao , Max Filippov , qemu-arm@nongnu.org, qemu-ppc@nongnu.org On 2016-06-10 19:26, Sergey Sorokin wrote: > There are functions cpu_unaligned_access() and do_unaligned_access() that > are called with access type and mmu index arguments. But these arguments > are named 'is_write' and 'is_user' in their declarations. > The patch fixes the names to avoid a confusion. Unless I missed something, it seems that the is_user/mmu_idx argument is never used. Should we maybe just drop it? Otherwise it looks fine. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net