From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com
Subject: Re: [PATCH] virtio: fix allocating virtnet_rx not mem aligned
Date: Mon, 13 Jun 2016 17:21:01 +0800 [thread overview]
Message-ID: <20160613092101.GN10038@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1465741782-126976-1-git-send-email-jianfeng.tan@intel.com>
On Sun, Jun 12, 2016 at 02:29:42PM +0000, Jianfeng Tan wrote:
> Compile DPDK with clang, below line in virtio_rxtx.c could be
> optimized with four "VMOVAPS ymm, m256".
> memset(&rxvq->fake_mbuf, 0, sizeof(rxvq->fake_mbuf));
>
> This instruction requires memory address is 32-byte aligned.
> Or, it leads to segfault.
That looks like a dangerous optimization to me. If that's the case,
doesn't it mean we have to make sure the address is always aligned
properly while calling memset?
--yliu
next prev parent reply other threads:[~2016-06-13 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 14:29 [PATCH] virtio: fix allocating virtnet_rx not mem aligned Jianfeng Tan
2016-06-13 9:21 ` Yuanhan Liu [this message]
2016-06-13 9:51 ` Yuanhan Liu
2016-06-13 10:06 ` Tan, Jianfeng
2016-06-13 10:26 ` Yuanhan Liu
2016-06-13 10:15 ` Tan, Jianfeng
2016-06-14 12:44 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613092101.GN10038@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.