From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk, Arnd Bergmann <arnd@arndb.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Alan Stern <stern@rowland.harvard.edu>,
Peter Chen <peter.chen@freescale.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: core: fix missing include <linux/usb/of.h>
Date: Mon, 13 Jun 2016 18:34:01 -0700 [thread overview]
Message-ID: <20160614013401.GA24636@kroah.com> (raw)
In-Reply-To: <1465323633-4851-1-git-send-email-ben.dooks@codethink.co.uk>
On Tue, Jun 07, 2016 at 07:20:33PM +0100, Ben Dooks wrote:
> The helper function usb_of_get_child_node() is defined in the
> header <linux/usb/of.h> but this was not included. Fix the warning
> about usb_of_get_child_node() not being declared by adding the
> right include. Fixes:
>
> drivers/usb/core/of.c:31:20: warning: symbol 'usb_of_get_child_node' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Given that the kbuild robot broke with this patch, I'm not going to take
it...
prev parent reply other threads:[~2016-06-14 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:20 [PATCH] USB: core: fix missing include <linux/usb/of.h> Ben Dooks
2016-06-07 19:04 ` kbuild test robot
2016-06-14 11:08 ` Arnd Bergmann
2016-06-15 2:43 ` Peter Chen
2016-06-16 12:45 ` Ben Dooks
2016-06-16 13:02 ` Ben Dooks
2016-06-17 1:31 ` Peter Chen
2016-06-14 1:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614013401.GA24636@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peter.chen@freescale.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.