All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2] block: drop support for using qcow[2] encryption with system emulators
Date: Wed, 15 Jun 2016 10:03:54 +0200	[thread overview]
Message-ID: <20160615080354.GD4566@noname.redhat.com> (raw)
In-Reply-To: <20160613153641.GF5968@noname.str.redhat.com>

Am 13.06.2016 um 17:36 hat Kevin Wolf geschrieben:
> Am 13.06.2016 um 13:30 hat Daniel P. Berrange geschrieben:
> > So rather than fix the crash, and backport it to stable
> > releases, just go ahead with what we have warned users about
> > and disable any use of qcow2 encryption in the system
> > emulators. qemu-img/qemu-io/qemu-nbd are still able to access
> > qcow2 encrypted images for the sake of data conversion.
> > 
> > In the future, qcow2 will gain support for the alternative
> > luks format, but when this happens it'll be using the
> > '-object secret' infrastructure for gettings keys, which
> > avoids this problematic scenario entirely.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> 
> Apart from the commit message comments above and from Eric, this looks
> good to me. I'll give a little more time for review before merging this.

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2016-06-15  8:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13 11:30 [Qemu-devel] [PATCH v2] block: drop support for using qcow[2] encryption with system emulators Daniel P. Berrange
2016-06-13 15:22 ` Eric Blake
2016-06-13 15:36 ` Kevin Wolf
2016-06-15  8:03   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615080354.GD4566@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.