From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: Moving drivers/leds/dell-led.c to drivers/platform/x86 Date: Wed, 15 Jun 2016 10:05:16 +0200 Message-ID: <20160615080516.GK29844@pali> References: <20160613134942.GA2824@eudyptula.hq.kempniu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20160613134942.GA2824@eudyptula.hq.kempniu.pl> Sender: platform-driver-x86-owner@vger.kernel.org To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Richard Purdie , Jacek Anaszewski , Matthew Garrett , Darren Hart , Bob Rodgers , Louis Davis , Jim Dailey , Alex Hung , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org On Monday 13 June 2016 15:49:42 Micha=C5=82 K=C4=99pie=C5=84 wrote: > Hi everyone, >=20 > Back in January [1], while working on the dell-smbios module, I > suggested that the code present in drivers/leds/dell-led.c could be > moved to drivers/platform/x86 for coherency. I decided to revisit th= at > idea. >=20 > dell-led consists of two major parts: >=20 > - the part handling an "Activity LED" present in Dell Latitude 2100 > netbooks, introduced in 72dcd8d; it registers a LED device and us= es > a special WMI interface to control its state, >=20 > - the part exposing a "microphone mute LED interface", introduced i= n > db6d8cc; this interface is used by sound/pci/hda/dell_wmi_helper.= c; > while the original implementation also used a WMI interface, it w= as > changed to use dell-smbios in cf0d7ea and 0c41a08. >=20 > I believe both parts could (and should) be moved to drivers/platform/= x86 > as drivers/platform/x86/dell-laptop.c already handles a bunch of LEDs > and drivers/leds/dell-led.c is the only dell-smbios user outside of > drivers/platform/x86. >=20 > My question to you, the maintainers of the relevant drivers and > subsystems, is whether you would like to see such a move happen. I h= ave > prepared a draft patch series which: >=20 > - moves the "microphone mute LED interface" to dell-laptop.c, > effectively causing sound/pci/hda/dell_wmi_helper.c to depend on > CONFIG_DELL_LAPTOP instead of CONFIG_LEDS_DELL_NETBOOKS, >=20 > - moves the "Activity LED" part to a new file, tentatively called > drivers/platform/x86/dell-wmi-led.c. >=20 > Merging the "Activity LED" part with drivers/platform/x86/dell-wmi.c = is > not really clean because dell-wmi handles a different GUID, which AFA= IK > is not related in any way to the GUID used by dell-led. >=20 > So, before I spam *three* subsystem mailing lists with a bunch of > patches, I would love to hear from the maintainers of both drivers/le= ds > and drivers/platform/x86 whether there are any arguments against such= a > move. Meanwhile, I will keep polishing the patch series and if there= is > no strong disagreement from any party involved, I will post the serie= s > next week or so, so that we can discuss code and not just ideas. >=20 > As a side note, if anyone reading this has access to a Dell device wh= ich > has an "Activity LED" and/or a "microphone mute LED" currently suppor= ted > by dell-led, I would love to hear from you as I do not have the hardw= are > needed to practically test the patch series I am working on. >=20 > Looking forward to hearing from you, >=20 > [1] https://www.spinics.net/lists/platform-driver-x86/msg08143.html I was talking with Micha=C5=82 and I supports this move. --=20 Pali Roh=C3=A1r pali.rohar@gmail.com