From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753424AbcFOIkq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 04:40:46 -0400
Received: from wtarreau.pck.nerim.net ([62.212.114.60]:50264 "EHLO 1wt.eu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751889AbcFOIko (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 04:40:44 -0400
Date: Wed, 15 Jun 2016 10:40:31 +0200
From: Willy Tarreau <w@1wt.eu>
To: Dave Young <dyoung@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Kees Cook <keescook@chromium.org>, Don Zickus <dzickus@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>, Hugh Dickins <hughd@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Daniel Cashman <dcashman@google.com>,
        Alexei Starovoitov <ast@plumgrid.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Ilya Dryomov <idryomov@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow
Message-ID: <20160615084031.GA5447@1wt.eu>
References: <1465608788-4813-1-git-send-email-xypron.glpk@gmx.de>
 <20160614131906.4a5a9db55946735fbd57c4f5@linux-foundation.org>
 <20160614204149.GA2723@1wt.eu>
 <20160615083332.GA6466@dhcp-128-65.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160615083332.GA6466@dhcp-128-65.nay.redhat.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 15, 2016 at 04:33:32PM +0800, Dave Young wrote:
> On 06/14/16 at 10:41pm, Willy Tarreau wrote:
> > On Tue, Jun 14, 2016 at 01:19:06PM -0700, Andrew Morton wrote:
> > > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> > > 
> > > > An undetected overflow may occur in do_proc_dointvec_minmax_conv_param.
> > > > 
> > > > ...
> > > >
> > > > --- a/kernel/sysctl.c
> > > > +++ b/kernel/sysctl.c
> > > > @@ -2313,7 +2313,17 @@ static int do_proc_dointvec_minmax_conv(bool *negp, unsigned long *lvalp,
> > > >  {
> > > >  	struct do_proc_dointvec_minmax_conv_param *param = data;
> > > >  	if (write) {
> > > > -		int val = *negp ? -*lvalp : *lvalp;
> > > > +		int val;
> > > > +
> > > > +		if (*negp) {
> > > > +			if (*lvalp > (unsigned long) INT_MAX + 1)
> > > > +				return -EINVAL;
> > > > +			val = -*lvalp;
> > > > +		} else {
> > > > +			if (*lvalp > (unsigned long) INT_MAX)
> > > > +				return -EINVAL;
> > > > +			val = *lvalp;
> > > > +		}
> > > >  		if ((param->min && *param->min > val) ||
> > > >  		    (param->max && *param->max < val))
> > > >  			return -EINVAL;
> > > 
> > > hm.
> > > 
> > > What happens if someone does
> > > 
> > > 	echo -1 > /proc/foo
> > > 
> > > expecting to get 0xffffffff?  That's a reasonable shorthand, and if we
> > > change that to spit out EINVAL then people's stuff may break.
> > 
> > I'd go even further, I don't see anymore how it becomes possible
> > to actually *write* 0xffffffff at all! This function is used by
> > proc_dointvec_minmax() which is used with extra1=&zero and extra2
> > not set with some unsigned ints to allow the full range to be
> > configured (eg: dirty_expire_interval is the first I found by a
> > quick random look).
> 
> sysctl_writes_strict use extra1 = -1 and extra2 = 1
> 
> But I do not get why -1 does not work, 1 < (unsigned long) INT_MAX + 1
> so val = -1, it is still right?

-1 should indeed work but 0xffffffff will definitely not.

Willy