From: Wei Liu <wei.liu2@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Dongli Zhang <dongli.zhang@oracle.com>,
xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>,
ian.jackson@eu.citrix.com, ross.lagerwall@citrix.com
Subject: Re: [PATCH v2 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); "
Date: Wed, 15 Jun 2016 10:10:20 +0100 [thread overview]
Message-ID: <20160615091019.GY28116@citrix.com> (raw)
In-Reply-To: <20160615090440.GA11583@gmail.com>
On Wed, Jun 15, 2016 at 11:04:40AM +0200, Olaf Hering wrote:
> On Wed, Jun 15, Wei Liu wrote:
>
> > To fix the breakage, please check out staging branch and write a patch
> > to fix it. And maybe the commit message should say something like
> > "initialise j to 0 to make some versions of gcc happy".
>
> Not "some", but rather "at least gcc4.5/4.3" or similar.
> There are already enough "some"s out there, where in the end noone knows
> what the given workaround is all about.
>
Fine by me of course. I didn't have a list of known offenders so I
couldn't suggest concrete version numbers.
Wei.
> Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-15 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 0:41 [PATCH v2 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); " Dongli Zhang
2016-06-15 8:52 ` Wei Liu
2016-06-15 9:04 ` Olaf Hering
2016-06-15 9:10 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615091019.GY28116@citrix.com \
--to=wei.liu2@citrix.com \
--cc=dongli.zhang@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=ross.lagerwall@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.