From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>, '@char.us.oracle.com
Cc: xen-devel@lists.xenproject.org, Tamas K Lengyel <tamas@tklengyel.com>
Subject: Re: [PATCH v5 1/2] x86/mem-sharing: Bulk mem-sharing entire domains
Date: Wed, 15 Jun 2016 10:02:14 -0400 [thread overview]
Message-ID: <20160615140214.GD9254@char.us.oracle.com> (raw)
In-Reply-To: <57612A7702000078000F5202@prv-mh.provo.novell.com>
On Wed, Jun 15, 2016 at 02:14:15AM -0600, Jan Beulich wrote:
> >>> On 14.06.16 at 18:33, <konrad.wilk@oracle.com> wrote:
> >> + /* Check for continuation if it's not the last iteration. */
> >> + if ( limit > ++bulk->start && hypercall_preempt_check() )
> >
> > I surprised the compiler didn't complain to you about lack of parenthesis.
>
> I'm puzzled - what kind of warning would you expect here? The
> compiler - afaik - treats relational operators vs logical AND/OR as
> having well known precedence wrt to one another; what iirc it
> would warn about is lack of parentheses in an expression using
> both of the logical operators, as people frequently don't know
> that && has higher precedence than ||.
Maybe those are the warnings I had seen in the past. I recall
that with a more modern compiler it would give me suggestions to
use parenthesis. But I honestly can't recall the details.
Either way - the code is fine.
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-15 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 23:24 [PATCH v5 1/2] x86/mem-sharing: Bulk mem-sharing entire domains Tamas K Lengyel
2016-06-11 23:24 ` [PATCH v5 2/2] tests/mem-sharing: Add bulk option to memshrtool Tamas K Lengyel
2016-06-12 0:08 ` [PATCH v5 1/2] x86/mem-sharing: Bulk mem-sharing entire domains Tamas K Lengyel
2016-06-14 9:56 ` Jan Beulich
2016-06-14 16:33 ` Konrad Rzeszutek Wilk
[not found] ` <CABfawhmqhAsEk=J5F3y0tAvd74xfi1_2-A+tfKzwCapcmL1zPg@mail.gmail.com>
[not found] ` <CABfawh=Hw-mZi+d751pRhA-C-wLOJ3TQPkW6rLAYp+GGGbxx1Q@mail.gmail.com>
[not found] ` <CABfawhnZVFt2Hwrfb+DNH3ft3gbB3Bc4+h7EpJfXbf=1_P-LWQ@mail.gmail.com>
[not found] ` <CABfawhkTvytb7NvHJ-AHJBCxA3wJ5Fo-ciV66JpSY-xdK+3v5Q@mail.gmail.com>
2016-06-14 16:42 ` Tamas K Lengyel
2016-06-15 8:14 ` Jan Beulich
2016-06-15 14:02 ` Konrad Rzeszutek Wilk [this message]
2016-06-22 15:38 ` George Dunlap
2016-06-23 15:42 ` Tamas K Lengyel
2016-07-05 14:35 ` George Dunlap
2016-07-05 14:58 ` Tamas K Lengyel
2016-07-05 14:59 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615140214.GD9254@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc='@char.us.oracle.com \
--cc=JBeulich@suse.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.