From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f70.google.com (mail-qg0-f70.google.com [209.85.192.70]) by kanga.kvack.org (Postfix) with ESMTP id 13B836B0260 for ; Wed, 15 Jun 2016 11:03:33 -0400 (EDT) Received: by mail-qg0-f70.google.com with SMTP id a95so49025671qgf.2 for ; Wed, 15 Jun 2016 08:03:33 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id t38si22513871qgt.91.2016.06.15.08.03.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2016 08:03:26 -0700 (PDT) Date: Wed, 15 Jun 2016 17:03:21 +0200 From: Oleg Nesterov Subject: Re: [PATCH 04/10] mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj Message-ID: <20160615150321.GD7944@redhat.com> References: <1465473137-22531-1-git-send-email-mhocko@kernel.org> <1465473137-22531-5-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465473137-22531-5-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Tetsuo Handa , David Rientjes , Vladimir Davydov , Andrew Morton , LKML , Michal Hocko On 06/09, Michal Hocko wrote: > > + if (!p->vfork_done && process_shares_mm(p, mm)) { > + pr_info("updating oom_score_adj for %d (%s) from %d to %d because it shares mm with %d (%s). Report if this is unexpected.\n", > + task_pid_nr(p), p->comm, > + p->signal->oom_score_adj, oom_adj, > + task_pid_nr(task), task->comm); > + p->signal->oom_score_adj = oom_adj; Personally I like this change. And. I think after this change we can actually move ->oom_score_adj into mm_struct, but lets discuss this later. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933152AbcFOPDb (ORCPT ); Wed, 15 Jun 2016 11:03:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57288 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932770AbcFOPD0 (ORCPT ); Wed, 15 Jun 2016 11:03:26 -0400 Date: Wed, 15 Jun 2016 17:03:21 +0200 From: Oleg Nesterov To: Michal Hocko Cc: linux-mm@kvack.org, Tetsuo Handa , David Rientjes , Vladimir Davydov , Andrew Morton , LKML , Michal Hocko Subject: Re: [PATCH 04/10] mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj Message-ID: <20160615150321.GD7944@redhat.com> References: <1465473137-22531-1-git-send-email-mhocko@kernel.org> <1465473137-22531-5-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465473137-22531-5-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 15 Jun 2016 15:03:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09, Michal Hocko wrote: > > + if (!p->vfork_done && process_shares_mm(p, mm)) { > + pr_info("updating oom_score_adj for %d (%s) from %d to %d because it shares mm with %d (%s). Report if this is unexpected.\n", > + task_pid_nr(p), p->comm, > + p->signal->oom_score_adj, oom_adj, > + task_pid_nr(task), task->comm); > + p->signal->oom_score_adj = oom_adj; Personally I like this change. And. I think after this change we can actually move ->oom_score_adj into mm_struct, but lets discuss this later. Oleg.