All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: board: cm-fx6: fix mmc for old revisions of utilite
Date: Wed, 15 Jun 2016 18:15:51 +0300	[thread overview]
Message-ID: <20160615151551.GA2833@arkadi-linux.compulab.local> (raw)
In-Reply-To: <d0e15b3c121b416fb280605ee1bd1800@rwthex-s1-b.rwth-ad.de>

Hi CHristopher,

On Wed, Jun 08, 2016 at 09:02:36PM +0200, Christopher Spinrath wrote:
> Old revisions of Utilite (based on cmfx6) do not have a dedicated
> card detect pin. But the card is removable by the user and card
> detection can be realized with polling (e.g. supported by Linux).
> 
> Add the broken-cd property to the mmc device tree instead of the
> non-removable property to make card detection possible if polling
> is supported.

Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
One nit-pick below:

> 
> Fixes: 41855186afd3 ("arm: mx6: cm-fx6: modify device tree for old revisions of utilite")

This isn't technically a fix; you're enabling new functionality. The
original behavior wasn't buggy, it just lacked the card detect feature.

> Signed-off-by: Christopher Spinrath <christopher.spinrath@rwth-aachen.de>
> ---
>  board/compulab/cm_fx6/cm_fx6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> -- 
> 2.8.3
>

Regards,
Nikita Kiryanov 

  reply	other threads:[~2016-06-15 15:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 19:02 [U-Boot] [PATCH] ARM: board: cm-fx6: fix mmc for old revisions of utilite Christopher Spinrath
2016-06-15 15:15 ` Nikita Kiryanov [this message]
     [not found] ` <d14689fedcc6431eb290feab11572a81@rwthex-w2-b.rwth-ad.de>
2016-06-15 15:38   ` Christopher Spinrath
2016-06-16  9:05     ` Igor Grinberg
2016-06-16 10:40     ` Nikita Kiryanov
     [not found]     ` <8541bdd129d345eda74f0bdb0444d2fc@rwthex-w2-a.rwth-ad.de>
2016-06-16 11:21       ` Christopher Spinrath
2016-06-16 12:46         ` Igor Grinberg
     [not found]     ` <f56e4e04d9ab4fb9bc974570a103a0d0@rwthex-w2-b.rwth-ad.de>
2016-06-16 11:22       ` Christopher Spinrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615151551.GA2833@arkadi-linux.compulab.local \
    --to=nikita@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.