From: Borislav Petkov <bp@alien8.de>
To: Tony Battersby <tonyb@cybernetics.com>
Cc: Borislav Petkov <bp@suse.de>,
Yazen Ghannam <yazen.ghannam@amd.com>,
linux-edac@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: lk 4.7 regression: EDAC, amd64_edac: Drop pci_register_driver() use
Date: Wed, 15 Jun 2016 23:50:26 +0200 [thread overview]
Message-ID: <20160615215026.GL30309@pd.tnic> (raw)
In-Reply-To: <5761CC0E.4040102@cybernetics.com>
On Wed, Jun 15, 2016 at 05:43:42PM -0400, Tony Battersby wrote:
> With that patch applied, modprobe amd64_edac_mod correctly reports "No
> such device" and everything is fine.
Good, thanks!
I'll add your Tested-by to the fix, if you don't mind.
> I also get a new line in dmesg on boot:
>
> amd_nb: Cannot enumerate AMD northbridges
Yeah, comes from init_amd_nbs(). I guess I can remove that pr_notice()
as it is unnecessary noise on distro kernels which enable AMD_NB.
> You might want to consider using -ENODEV instead of -1 for callers such
> as init_amd_nbs() that use the error value.
Yeah, already changed to -ENODEV :-)
Thanks for reporting and testing!
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-06-15 21:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:46 lk 4.7 regression: EDAC, amd64_edac: Drop pci_register_driver() use Tony Battersby
2016-06-15 21:12 ` Borislav Petkov
2016-06-15 21:43 ` Tony Battersby
2016-06-15 21:50 ` Borislav Petkov [this message]
2016-06-15 21:58 ` Tony Battersby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615215026.GL30309@pd.tnic \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tonyb@cybernetics.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.