From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660
Date: Wed, 15 Jun 2016 17:20:24 -0700 [thread overview]
Message-ID: <20160616002024.GO28218@codeaurora.org> (raw)
In-Reply-To: <1465945346-29298-1-git-send-email-linus.walleij@linaro.org>
On 06/15, Linus Walleij wrote:
> @@ -426,10 +447,11 @@ static irqreturn_t qcom_rpm_ack_interrupt(int irq, void *dev)
> u32 ack;
> int i;
>
> - ack = readl_relaxed(RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
> - for (i = 0; i < RPM_SELECT_SIZE; i++)
> - writel_relaxed(0, RPM_CTRL_REG(rpm, RPM_ACK_SELECTOR + i));
> - writel(0, RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
> + ack = readl_relaxed(RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));
> + for (i = 0; i < rpm->data->sel_size; i++)
> + writel_relaxed(0,
> + RPM_CTRL_REG(rpm, rpm->data->ack_sel_off + i));
> + writel(0, RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));
Does the ack size vary though? I thought that was always 7. It
seems that really only the request selector size varies?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-06-16 0:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 23:02 [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660 Linus Walleij
2016-06-15 8:38 ` Lee Jones
2016-06-16 0:20 ` Stephen Boyd [this message]
2016-06-16 7:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616002024.GO28218@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.