Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 0/9] Core based CPU hotplug for PowerPC sPAPR

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

On Thu, Jun 16, 2016 at 09:19:52AM +0530, Bharata B Rao wrote:
> On Wed, Jun 15, 2016 at 04:04:14PM +1000, David Gibson wrote:
> > On Fri, Jun 10, 2016 at 03:14:14PM +1000, David Gibson wrote:
> > > On Fri, Jun 10, 2016 at 06:28:59AM +0530, Bharata B Rao wrote:
> > > > Hi,
> > > > 
> > > > This is the next version of the CPU hotplug patchset for PowerPC
> > > > sPAPR target. The hotplug semantics looks like this:
> > > > 
> > > > (qemu) device_add POWER8E-spapr-cpu-core,id=core2,core-id=16[,threads=4]
> > > > (qemu) device_add host-spapr-cpu-core,id=core2,core-id=16[,threads=4]
> > > > (qemu) device_add
> > > > POWER8E_v2.1-spapr-cpu-core,id=core2,core-id=16[,threads=4]
> > > 
> > > I've merged these to my ppc-cpu-hotplug branch, and I'm doing some
> > > testing.  It it checks out, I hope to send a pull request.
> > 
> > I've now merged this into my main ppc-for-2.7 branch.  I'll be doing
> > some testing, obviously, but I'd certain appreciate any other tests of
> > this branch with the hotplug code.
> 
> David, I don't see the unplug patch in your tree, intentional ?

Oops, no.  I've added it now.

> Also I am working on supporting the CPU compat settings with the following
> semantics:
> 
> -cpu host,power7 -device host-spapr-cpu-core,compat-cpu=power7
> 
> Whatever CPU compat level that is specifed with -cpu host is considered
> as base and the compat-cpu property specified with -device will be
> validated against the base compat level. And this property 'compat-cpu'
> will be supported only for host-spapr-cpu-core type.
> 
> Is this semantics fine ?

Uh.. I think so.  The semantics of cpu compat modes have always
confused me.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]