All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Alex Hung <alex.hung@canonical.com>
Cc: mjg59@srcf.ucam.org, dvhart@infradead.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] dell-wmi: add a WMI event code for display on/off
Date: Thu, 16 Jun 2016 09:37:27 +0200	[thread overview]
Message-ID: <20160616073727.GU29844@pali> (raw)
In-Reply-To: <1466047508-18799-1-git-send-email-alex.hung@canonical.com>

On Thursday 16 June 2016 11:25:08 Alex Hung wrote:
> Some new Dell AIO systems have a button that generates WMI evnet
> that is to be used to turn LCD on/off
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/platform/x86/dell-wmi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 15c6f11..298aba1 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -125,6 +125,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
>  	/* Audio panel key */
>  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
>  
> +	/* Monitor On/Off Control key */
> +	{ KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
> +
>  	{ KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
>  	{ KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
>  	{ KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },

Hi! Can you rebase this path on top of my "[PATCH v3 0/4] dell-wmi:
Changes in WMI event code handling" series? As it changes order of keys
in that sparse table and your change should be easy to rebase.

After rebasing needs some whitespace changes, but looks good, add my
Acked-by.

-- 
Pali Rohár
pali.rohar@gmail.com

      reply	other threads:[~2016-06-16  7:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16  3:25 [PATCH] dell-wmi: add a WMI event code for display on/off Alex Hung
2016-06-16  7:37 ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160616073727.GU29844@pali \
    --to=pali.rohar@gmail.com \
    --cc=alex.hung@canonical.com \
    --cc=dvhart@infradead.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.