From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module Date: Thu, 16 Jun 2016 15:22:22 +0100 Message-ID: <20160616142222.GW4948@dell> References: <1464280340-13228-1-git-send-email-javier@osg.samsung.com> <1464280340-13228-3-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:36644 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbcFPOVl (ORCPT ); Thu, 16 Jun 2016 10:21:41 -0400 Received: by mail-wm0-f45.google.com with SMTP id f126so53112640wma.1 for ; Thu, 16 Jun 2016 07:21:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1464280340-13228-3-git-send-email-javier@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Chanwoo Choi On Thu, 26 May 2016, Javier Martinez Canillas wrote: > The driver's Kconfig symbol is a boolean but nothing prevents the dri= ver > to be built as a module instead of built-in. It is true that most sys= tem > integrators will choose the latter but the config should not restrict= it. >=20 > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas >=20 > --- >=20 > drivers/mfd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index a49565cc1a6b..33d112f390fe 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -514,8 +514,8 @@ config MFD_88PM860X > battery-charger under the corresponding menus. > =20 > config MFD_MAX14577 > - bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" > - depends on I2C=3Dy > + tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support= " > + depends on I2C > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog