From mboxrd@z Thu Jan  1 00:00:00 1970
From: will.deacon@arm.com (Will Deacon)
Date: Thu, 16 Jun 2016 17:43:11 +0100
Subject: [PATCH v5] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs
In-Reply-To: <1466083730-11786-1-git-send-email-suzuki.poulose@arm.com>
References: <1466083730-11786-1-git-send-email-suzuki.poulose@arm.com>
Message-ID: <20160616164311.GH5827@arm.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, Jun 16, 2016 at 02:28:50PM +0100, Suzuki K Poulose wrote:
> +static int __init cpuinfo_regs_init(void)
> +{
> +	int cpu, finalcpu, ret;
> +	struct device *dev;
> +
> +	cpu_hotplug_disable();
> +
> +	for_each_present_cpu(cpu) {
> +		dev = get_cpu_device(cpu);
> +
> +		if (!dev) {
> +			ret = -ENODEV;
> +			break;
> +		}
> +
> +		ret = sysfs_create_group(&dev->kobj, &cpuregs_attr_group);
> +		if (ret)
> +			break;
> +	}
> +
> +	if (!ret)
> +		goto out;
> +	/*
> +	 * We were unable to put down sysfs groups for all the CPUs, revert
> +	 * all the groups we have placed down s.t. none are visible.
> +	 * Otherwise we could give a misleading picture of what's present.
> +	 */
> +	finalcpu = cpu;
> +	for_each_present_cpu(cpu) {
> +		if (cpu == finalcpu)
> +			break;
> +		dev = get_cpu_device(cpu);
> +		if (dev)
> +			sysfs_remove_group(&dev->kobj, &cpuregs_attr_group);
> +	}
> +
> +out:
> +	cpu_hotplug_enable();
> +	return ret;
> +}
> +
> +device_initcall(cpuinfo_regs_init);

Given that you're built the sysfs entries out of the present mask, don't
you need a hotplug notifier to keep things up to date?

Will

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754718AbcFPQnV (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Jun 2016 12:43:21 -0400
Received: from foss.arm.com ([217.140.101.70]:45131 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754628AbcFPQnU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Jun 2016 12:43:20 -0400
Date: Thu, 16 Jun 2016 17:43:11 +0100
From: Will Deacon <will.deacon@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, steve.capper@linaro.org,
        linux@arm.linux.org.uk, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v5] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to
 sysfs
Message-ID: <20160616164311.GH5827@arm.com>
References: <1466083730-11786-1-git-send-email-suzuki.poulose@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1466083730-11786-1-git-send-email-suzuki.poulose@arm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 16, 2016 at 02:28:50PM +0100, Suzuki K Poulose wrote:
> +static int __init cpuinfo_regs_init(void)
> +{
> +	int cpu, finalcpu, ret;
> +	struct device *dev;
> +
> +	cpu_hotplug_disable();
> +
> +	for_each_present_cpu(cpu) {
> +		dev = get_cpu_device(cpu);
> +
> +		if (!dev) {
> +			ret = -ENODEV;
> +			break;
> +		}
> +
> +		ret = sysfs_create_group(&dev->kobj, &cpuregs_attr_group);
> +		if (ret)
> +			break;
> +	}
> +
> +	if (!ret)
> +		goto out;
> +	/*
> +	 * We were unable to put down sysfs groups for all the CPUs, revert
> +	 * all the groups we have placed down s.t. none are visible.
> +	 * Otherwise we could give a misleading picture of what's present.
> +	 */
> +	finalcpu = cpu;
> +	for_each_present_cpu(cpu) {
> +		if (cpu == finalcpu)
> +			break;
> +		dev = get_cpu_device(cpu);
> +		if (dev)
> +			sysfs_remove_group(&dev->kobj, &cpuregs_attr_group);
> +	}
> +
> +out:
> +	cpu_hotplug_enable();
> +	return ret;
> +}
> +
> +device_initcall(cpuinfo_regs_init);

Given that you're built the sysfs entries out of the present mask, don't
you need a hotplug notifier to keep things up to date?

Will