From: "Michael Büsch" <m@bues.ch>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [v3,1/2] b43: Remove unused phy_a code
Date: Thu, 16 Jun 2016 17:48:13 +0200 [thread overview]
Message-ID: <20160616174813.595440bb@wiggum> (raw)
In-Reply-To: <20160616152337.63AB261421@smtp.codeaurora.org>
On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
Kalle Valo <kvalo@codeaurora.org> wrote:
> Guenter Roeck <linux@roeck-us.net> wrote:
> > gcc-6 reports the following error with -Werror=unused-const-variable.
> >
> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> > 'b43_phyops_a' defined but not used
> >
> > Per Michael B?sch: "All a-phy code is usused", so remove it all,
> > and move the remaining Type-G initialization code into phy_g.c.
> >
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
> > Cc: Michael B?sch <m@bues.ch>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks, 2 patches applied to wireless-drivers-next.git:
>
> 9791333a840f b43: Remove unused phy_a code
> afdfdc481ea9 b43: Completely remove support for phy_a
Did anybody test this on any hardware?
I think this should be tested on some G-PHY hardware, before it goes to
Linus.
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20160616/402135be/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [v3,1/2] b43: Remove unused phy_a code
Date: Thu, 16 Jun 2016 17:48:13 +0200 [thread overview]
Message-ID: <20160616174813.595440bb@wiggum> (raw)
In-Reply-To: <20160616152337.63AB261421@smtp.codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
Kalle Valo <kvalo@codeaurora.org> wrote:
> Guenter Roeck <linux@roeck-us.net> wrote:
> > gcc-6 reports the following error with -Werror=unused-const-variable.
> >
> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
> > 'b43_phyops_a' defined but not used
> >
> > Per Michael Büsch: "All a-phy code is usused", so remove it all,
> > and move the remaining Type-G initialization code into phy_g.c.
> >
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
> > Cc: Michael Büsch <m@bues.ch>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks, 2 patches applied to wireless-drivers-next.git:
>
> 9791333a840f b43: Remove unused phy_a code
> afdfdc481ea9 b43: Completely remove support for phy_a
Did anybody test this on any hardware?
I think this should be tested on some G-PHY hardware, before it goes to
Linus.
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-16 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 14:54 [PATCH v3 1/2] b43: Remove unused phy_a code Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 14:54 ` [PATCH v3 2/2] b43: Completely remove support for phy_a Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 14:54 ` Guenter Roeck
2016-06-04 21:23 ` [PATCH v3 1/2] b43: Remove unused phy_a code Larry Finger
2016-06-04 21:23 ` Larry Finger
2016-06-16 15:23 ` [v3,1/2] " Kalle Valo
2016-06-16 15:23 ` Kalle Valo
2016-06-16 15:48 ` Michael Büsch [this message]
2016-06-16 15:48 ` Michael Büsch
2016-06-16 15:56 ` Kalle Valo
2016-06-16 15:56 ` Kalle Valo
2016-06-16 16:05 ` Michael Büsch
2016-06-16 16:05 ` Michael Büsch
2016-06-16 15:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616174813.595440bb@wiggum \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.