From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcelo.leitner@gmail.com Date: Thu, 16 Jun 2016 21:13:22 +0000 Subject: Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate Message-Id: <20160616211322.GW22680@localhost.localdomain> List-Id: References: <9229f8aa0f4324831fc31b5334cde9a258404b62.1466010906.git.lucien.xin@gmail.com> <20160616.141139.1258089118185183298.davem@davemloft.net> In-Reply-To: <20160616.141139.1258089118185183298.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: lucien.xin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, vyasevich@gmail.com, daniel@iogearbox.net, xiaolong.ye@intel.com, eric.dumazet@gmail.com On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote: > From: Xin Long > Date: Thu, 16 Jun 2016 01:15:06 +0800 > > > Commit d46e416c11c8 ("sctp: sctp should change socket state when > > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate, > > but inet_accept doesn't allow the sk_state other than ESTABLISHED/ > > CLOSED for sctp. So we will change sk_state to CLOSED, instead of > > CLOSING, as actually sk is closed already there. > > > > Fixes: commit d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received") > > Reported-by: Ye Xiaolong > > Signed-off-by: Xin Long > > Applied. I thought Xin was going to post a version with that tag Fixed, but ok. Patch is good to me, fwiw. From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcelo.leitner@gmail.com Subject: Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock_migrate Date: Thu, 16 Jun 2016 18:13:22 -0300 Message-ID: <20160616211322.GW22680@localhost.localdomain> References: <9229f8aa0f4324831fc31b5334cde9a258404b62.1466010906.git.lucien.xin@gmail.com> <20160616.141139.1258089118185183298.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lucien.xin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, vyasevich@gmail.com, daniel@iogearbox.net, xiaolong.ye@intel.com, eric.dumazet@gmail.com To: David Miller Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbcFPVN0 (ORCPT ); Thu, 16 Jun 2016 17:13:26 -0400 Content-Disposition: inline In-Reply-To: <20160616.141139.1258089118185183298.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote: > From: Xin Long > Date: Thu, 16 Jun 2016 01:15:06 +0800 > > > Commit d46e416c11c8 ("sctp: sctp should change socket state when > > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate, > > but inet_accept doesn't allow the sk_state other than ESTABLISHED/ > > CLOSED for sctp. So we will change sk_state to CLOSED, instead of > > CLOSING, as actually sk is closed already there. > > > > Fixes: commit d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received") > > Reported-by: Ye Xiaolong > > Signed-off-by: Xin Long > > Applied. I thought Xin was going to post a version with that tag Fixed, but ok. Patch is good to me, fwiw.