Re: [PATCH] xen: sched: use default scheduler upon an invalid "sched="

[Wei Liu <wei.liu2@citrix.com>]

On Fri, Jun 17, 2016 at 12:31:00PM +0200, Dario Faggioli wrote:
> instead of just the first scheduler we find in the array.
> 
> In fact, right now, if someone makes a typo when passing
> the "sched=" command line option to Xen, we (with all
> schedulers configured in) pick ARINC653, which is most
> likely not what one would expect.
> 
> Go for the default scheduler instead.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Doug Goldstein <cardoe@cardoe.com>
> Cc: Jonathan Creekmore <jonathan.creekmore@gmail.com>
> ---
> I don't think I'm going to ask for this to be put in 4.7,
> as I don't want to give Wei an heart attack... :-)
> 

I will just say "Meh, let's backport this." :-P

> Considering it for backporting should be enough, IMO.
> ---
>  xen/common/schedule.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/schedule.c b/xen/common/schedule.c
> index 5e35310..7ac12d3 100644
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -1625,7 +1625,8 @@ void __init scheduler_init(void)
>      {
>          printk("Could not find scheduler: %s\n", opt_sched);
>          for ( i = 0; i < NUM_SCHEDULERS; i++ )
> -            if ( schedulers[i] )
> +            if ( schedulers[i] &&
> +                 !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) )
>              {
>                  ops = *schedulers[i];
>                  break;
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel