From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64 Date: Fri, 17 Jun 2016 20:18:10 -0700 Message-ID: <20160618031810.GA29160@kroah.com> References: <61880bededb77bbc3ea3422e48ce717d2a2ff489.1464380034.git.vilhelm.gray@gmail.com> <20160531112251.GA5674@sophia> <20160531152541.GB13304@kroah.com> <057d8c0b-074c-609a-35da-5a01f07b6d31@leemhuis.info> <20160618023607.GA7390@kroah.com> <20160618024959.GA4702@sophia> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34059 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbcFRDSL (ORCPT ); Fri, 17 Jun 2016 23:18:11 -0400 Content-Disposition: inline In-Reply-To: <20160618024959.GA4702@sophia> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: William Breathitt Gray Cc: Thorsten Leemhuis , Linus Walleij , Andrew Morton , x86@kernel.org, "linux-next@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-watchdog@vger.kernel.org, Stephen Rothwell , Guenter Roeck , Alexandre Courbot On Fri, Jun 17, 2016 at 10:49:59PM -0400, William Breathitt Gray wrote: > On Fri, Jun 17, 2016 at 07:36:07PM -0700, Greg KH wrote: > >On Fri, Jun 17, 2016 at 12:47:14PM +0200, Thorsten Leemhuis wrote: > >> On 31.05.2016 17:25, Greg KH wrote: > >> > On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray= wrote: > >> >> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote: > >> >>> On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray > >> >>> wrote: > >> >>>> With the introduction of the ISA_BUS_API Kconfig option, ISA-= style > >> >>>> drivers may be built for X86_64 architectures. This patch cha= nges the > >> >>>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BU= S_API, thus > >> >>>> allowing them to build for X86_64 as they are expected to. > >> > [=E2=80=A6] > >> >> Greg K-H, > >> >> > >> >> Would you be able to pick up this entire patchset via driver-co= re; I > >> >> figure that tree is the most appropriate to receive any core IS= A bus > >> >> driver changes (unless you see a more fitting path to take). > >> > [=E2=80=A6] > >> > Yes, I can take this through the driver core tree as that's wher= e the > >> > original series came from... > >>=20 > >> Was this series merged or did it fell through the cracks? I curren= tly > >> assume the latter, as I can't see it in neither mainline nor linux= -next > >> (but maybe I'm missing something). Just wondering, because I have = this > >> issue on my regression list for 4.7. > >>=20 > >> For the whole context see: > >> http://thread.gmane.org/gmane.linux.kernel.gpio/17016/ > >>=20 > >> Sincerely, your regression tracker for Linux 4.7 (http://bit.ly/28= JRmJo) > > > >I don't think this is a regression, I was going to queue these up fo= r > >4.8-rc1. As it is now, 4.7-rc is working just fine in this regards, > >right? > > > >Or am I missing something? >=20 > The PC/104 drivers were changed to utilize the ISA bus driver as part= of > the original patchset which attempted to decouple the X86_32 dependen= cy > from the ISA Kconfig option; these drivers were updated with the > intention of building on X86_64 in addition to X86_32. >=20 > However, the respective patches were merged without the decoupling > changes (since decoupling was the wrong approach), resulting in an > unintentional regression: the PC/104 drivers are now restricted to > X86_32 due to the ISA Kconfig option dependency, while they were capa= ble > of building for X86_64 in previous kernel versions. >=20 > This patchset should fix this regression by introducing the ISA_BUS_A= PI > Kconfig option, and the respective Kconfig dependency changes for the > drivers, in order to allow them to build for both X86_64 and X86_32 a= s > originally capable. Ah, ok, that makes more sense, thanks. I'll go queue these up now. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34059 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbcFRDSL (ORCPT ); Fri, 17 Jun 2016 23:18:11 -0400 Date: Fri, 17 Jun 2016 20:18:10 -0700 From: Greg KH To: William Breathitt Gray Cc: Thorsten Leemhuis , Linus Walleij , Andrew Morton , x86@kernel.org, "linux-next@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-watchdog@vger.kernel.org, Stephen Rothwell , Guenter Roeck , Alexandre Courbot Subject: Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64 Message-ID: <20160618031810.GA29160@kroah.com> References: <61880bededb77bbc3ea3422e48ce717d2a2ff489.1464380034.git.vilhelm.gray@gmail.com> <20160531112251.GA5674@sophia> <20160531152541.GB13304@kroah.com> <057d8c0b-074c-609a-35da-5a01f07b6d31@leemhuis.info> <20160618023607.GA7390@kroah.com> <20160618024959.GA4702@sophia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20160618024959.GA4702@sophia> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Fri, Jun 17, 2016 at 10:49:59PM -0400, William Breathitt Gray wrote: > On Fri, Jun 17, 2016 at 07:36:07PM -0700, Greg KH wrote: > >On Fri, Jun 17, 2016 at 12:47:14PM +0200, Thorsten Leemhuis wrote: > >> On 31.05.2016 17:25, Greg KH wrote: > >> > On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray wrote: > >> >> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote: > >> >>> On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray > >> >>> wrote: > >> >>>> With the introduction of the ISA_BUS_API Kconfig option, ISA-style > >> >>>> drivers may be built for X86_64 architectures. This patch changes the > >> >>>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus > >> >>>> allowing them to build for X86_64 as they are expected to. > >> > […] > >> >> Greg K-H, > >> >> > >> >> Would you be able to pick up this entire patchset via driver-core; I > >> >> figure that tree is the most appropriate to receive any core ISA bus > >> >> driver changes (unless you see a more fitting path to take). > >> > […] > >> > Yes, I can take this through the driver core tree as that's where the > >> > original series came from... > >> > >> Was this series merged or did it fell through the cracks? I currently > >> assume the latter, as I can't see it in neither mainline nor linux-next > >> (but maybe I'm missing something). Just wondering, because I have this > >> issue on my regression list for 4.7. > >> > >> For the whole context see: > >> http://thread.gmane.org/gmane.linux.kernel.gpio/17016/ > >> > >> Sincerely, your regression tracker for Linux 4.7 (http://bit.ly/28JRmJo) > > > >I don't think this is a regression, I was going to queue these up for > >4.8-rc1. As it is now, 4.7-rc is working just fine in this regards, > >right? > > > >Or am I missing something? > > The PC/104 drivers were changed to utilize the ISA bus driver as part of > the original patchset which attempted to decouple the X86_32 dependency > from the ISA Kconfig option; these drivers were updated with the > intention of building on X86_64 in addition to X86_32. > > However, the respective patches were merged without the decoupling > changes (since decoupling was the wrong approach), resulting in an > unintentional regression: the PC/104 drivers are now restricted to > X86_32 due to the ISA Kconfig option dependency, while they were capable > of building for X86_64 in previous kernel versions. > > This patchset should fix this regression by introducing the ISA_BUS_API > Kconfig option, and the respective Kconfig dependency changes for the > drivers, in order to allow them to build for both X86_64 and X86_32 as > originally capable. Ah, ok, that makes more sense, thanks. I'll go queue these up now. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34059 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbcFRDSL (ORCPT ); Fri, 17 Jun 2016 23:18:11 -0400 Date: Fri, 17 Jun 2016 20:18:10 -0700 From: Greg KH To: William Breathitt Gray Cc: Thorsten Leemhuis , Linus Walleij , Andrew Morton , x86@kernel.org, "linux-next@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-watchdog@vger.kernel.org, Stephen Rothwell , Guenter Roeck , Alexandre Courbot Subject: Re: [PATCH v5 2/4] gpio: Allow PC/104 devices on X86_64 Message-ID: <20160618031810.GA29160@kroah.com> References: <61880bededb77bbc3ea3422e48ce717d2a2ff489.1464380034.git.vilhelm.gray@gmail.com> <20160531112251.GA5674@sophia> <20160531152541.GB13304@kroah.com> <057d8c0b-074c-609a-35da-5a01f07b6d31@leemhuis.info> <20160618023607.GA7390@kroah.com> <20160618024959.GA4702@sophia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160618024959.GA4702@sophia> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable On Fri, Jun 17, 2016 at 10:49:59PM -0400, William Breathitt Gray wrote: > On Fri, Jun 17, 2016 at 07:36:07PM -0700, Greg KH wrote: > >On Fri, Jun 17, 2016 at 12:47:14PM +0200, Thorsten Leemhuis wrote: > >> On 31.05.2016 17:25, Greg KH wrote: > >> > On Tue, May 31, 2016 at 07:23:06AM -0400, William Breathitt Gray w= rote: > >> >> On Tue, May 31, 2016 at 10:41:49AM +0200, Linus Walleij wrote: > >> >>> On Sat, May 28, 2016 at 12:08 AM, William Breathitt Gray > >> >>> wrote: > >> >>>> With the introduction of the ISA_BUS_API Kconfig option, ISA-st= yle > >> >>>> drivers may be built for X86_64 architectures. This patch chang= es the > >> >>>> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_= API, thus > >> >>>> allowing them to build for X86_64 as they are expected to. > >> > [=E2=80=A6] > >> >> Greg K-H, > >> >> > >> >> Would you be able to pick up this entire patchset via driver-core= ; I > >> >> figure that tree is the most appropriate to receive any core ISA = bus > >> >> driver changes (unless you see a more fitting path to take). > >> > [=E2=80=A6] > >> > Yes, I can take this through the driver core tree as that's where = the > >> > original series came from... > >>=20 > >> Was this series merged or did it fell through the cracks? I currentl= y > >> assume the latter, as I can't see it in neither mainline nor linux-n= ext > >> (but maybe I'm missing something). Just wondering, because I have th= is > >> issue on my regression list for 4.7. > >>=20 > >> For the whole context see: > >> http://thread.gmane.org/gmane.linux.kernel.gpio/17016/ > >>=20 > >> Sincerely, your regression tracker for Linux 4.7 (http://bit.ly/28JR= mJo) > > > >I don't think this is a regression, I was going to queue these up for > >4.8-rc1. As it is now, 4.7-rc is working just fine in this regards, > >right? > > > >Or am I missing something? >=20 > The PC/104 drivers were changed to utilize the ISA bus driver as part o= f > the original patchset which attempted to decouple the X86_32 dependency > from the ISA Kconfig option; these drivers were updated with the > intention of building on X86_64 in addition to X86_32. >=20 > However, the respective patches were merged without the decoupling > changes (since decoupling was the wrong approach), resulting in an > unintentional regression: the PC/104 drivers are now restricted to > X86_32 due to the ISA Kconfig option dependency, while they were capabl= e > of building for X86_64 in previous kernel versions. >=20 > This patchset should fix this regression by introducing the ISA_BUS_API > Kconfig option, and the respective Kconfig dependency changes for the > drivers, in order to allow them to build for both X86_64 and X86_32 as > originally capable. Ah, ok, that makes more sense, thanks. I'll go queue these up now. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html