From: Greg KH <gregkh@linuxfoundation.org>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Ashwin Ravichandran <ashwinravichandran24@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
Date: Fri, 17 Jun 2016 21:01:43 -0700 [thread overview]
Message-ID: <20160618040143.GD5854@kroah.com> (raw)
In-Reply-To: <574EAC7D.9070001@mev.co.uk>
On Wed, Jun 01, 2016 at 10:35:57AM +0100, Ian Abbott wrote:
> On 01/06/16 10:19, Ashwin Ravichandran wrote:
> > Fixed a coding style issue.
> >
> > Signed-off-by: Ashwin Ravichandran <ashwinravichandran24@gmail.com>
> > ---
> > drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
> > drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> > index 3757074..9c27999 100644
> > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> > @@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev,
> > data[0] != ADDIDATA_TIMER)
> > return -EINVAL;
> >
> > - devpriv->tsk_Current = current;
> > + devpriv->tsk_current = current;
> >
> > devpriv->timer_mode = data[0];
> >
> > diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> > index 40ff914..b2f6712 100644
> > --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> > +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> > @@ -68,7 +68,7 @@
> > struct apci3501_private {
> > unsigned long amcc;
> > unsigned long tcw;
> > - struct task_struct *tsk_Current;
> > + struct task_struct *tsk_current;
> > unsigned char timer_mode;
> > };
> >
> > @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> > }
> >
> > /* Enable Interrupt Send a signal to from kernel to user space */
> > - send_sig(SIGIO, devpriv->tsk_Current, 0);
> > + send_sig(SIGIO, devpriv->tsk_current, 0);
> > ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
> > ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
> > ADDI_TCW_CTRL_IRQ_ENA);
> >
>
> The patch looks fine (although this odd-ball Comedi driver shouldn't really
> be sending signals to a user-space task!).
Yeah, that's really odd, fixing that would be nice...
next prev parent reply other threads:[~2016-06-18 4:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 9:19 [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue Ashwin Ravichandran
2016-06-01 9:35 ` Ian Abbott
2016-06-18 4:01 ` Greg KH [this message]
2016-06-20 17:22 ` Hartley Sweeten
2016-06-18 4:01 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-06-01 6:00 Ashwin
2016-06-01 6:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160618040143.GD5854@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=ashwinravichandran24@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.