From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sat, 18 Jun 2016 08:38:44 +0000 Subject: [patch] drm/amdgpu: precedence bug in amdgpu_device_init() Message-Id: <20160618083844.GA21713@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Deucher , Andres Rodriguez Cc: Tom St Denis , Jammy Zhou , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Flora Cui , Christian =?iso-8859-1?Q?K=F6nig?= , Monk Liu ! has higher precedence than bitwise & so we need to add parenthesis for this to work as intended. Fixes: 048765ad5af7 ('amdgpu: fix asic initialization for virtualized environments (v2)') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 66482b4..6e92008 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -1535,7 +1535,7 @@ int amdgpu_device_init(struct amdgpu_device *adev, /* Post card if necessary */ if (!amdgpu_card_posted(adev) || (adev->virtualization.is_virtual && - !adev->virtualization.caps & AMDGPU_VIRT_CAPS_SRIOV_EN)) { + !(adev->virtualization.caps & AMDGPU_VIRT_CAPS_SRIOV_EN))) { if (!adev->bios) { dev_err(adev->dev, "Card not posted and no BIOS - ignoring\n"); return -EINVAL; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/amdgpu: precedence bug in amdgpu_device_init() Date: Sat, 18 Jun 2016 11:38:44 +0300 Message-ID: <20160618083844.GA21713@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99E966E1A1 for ; Sat, 18 Jun 2016 08:39:02 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , Andres Rodriguez Cc: Tom St Denis , Jammy Zhou , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Flora Cui , Christian =?iso-8859-1?Q?K=F6nig?= , Monk Liu List-Id: dri-devel@lists.freedesktop.org ISBoYXMgaGlnaGVyIHByZWNlZGVuY2UgdGhhbiBiaXR3aXNlICYgc28gd2UgbmVlZCB0byBhZGQg cGFyZW50aGVzaXMKZm9yIHRoaXMgdG8gd29yayBhcyBpbnRlbmRlZC4KCkZpeGVzOiAwNDg3NjVh ZDVhZjcgKCdhbWRncHU6IGZpeCBhc2ljIGluaXRpYWxpemF0aW9uIGZvciB2aXJ0dWFsaXplZCBl bnZpcm9ubWVudHMgKHYyKScpClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJw ZW50ZXJAb3JhY2xlLmNvbT4KCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfZGV2aWNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2 aWNlLmMKaW5kZXggNjY0ODJiNC4uNmU5MjAwOCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9kZXZpY2UuYwpAQCAtMTUzNSw3ICsxNTM1LDcgQEAgaW50IGFtZGdwdV9kZXZp Y2VfaW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKIAkvKiBQb3N0IGNhcmQgaWYgbmVj ZXNzYXJ5ICovCiAJaWYgKCFhbWRncHVfY2FyZF9wb3N0ZWQoYWRldikgfHwKIAkgICAgKGFkZXYt PnZpcnR1YWxpemF0aW9uLmlzX3ZpcnR1YWwgJiYKLQkgICAgICFhZGV2LT52aXJ0dWFsaXphdGlv bi5jYXBzICYgQU1ER1BVX1ZJUlRfQ0FQU19TUklPVl9FTikpIHsKKwkgICAgICEoYWRldi0+dmly dHVhbGl6YXRpb24uY2FwcyAmIEFNREdQVV9WSVJUX0NBUFNfU1JJT1ZfRU4pKSkgewogCQlpZiAo IWFkZXYtPmJpb3MpIHsKIAkJCWRldl9lcnIoYWRldi0+ZGV2LCAiQ2FyZCBub3QgcG9zdGVkIGFu ZCBubyBCSU9TIC0gaWdub3JpbmdcbiIpOwogCQkJcmV0dXJuIC1FSU5WQUw7Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=