From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bin Gao <bin.gao@linux.intel.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
Yegnesh S Iyer <yegnesh.s.iyer@intel.com>,
Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver
Date: Mon, 20 Jun 2016 10:37:24 +0300 [thread overview]
Message-ID: <20160620073724.GS1739@lahna.fi.intel.com> (raw)
In-Reply-To: <20160620035431.GA236937@worksta>
On Sun, Jun 19, 2016 at 08:54:32PM -0700, Bin Gao wrote:
> > > +#define DRV_NAME "bxt_wcove_gpio"
> >
> > Drop this.
> We have _TWO_ places using DRV_NAME(near the end of the file):
> static struct platform_driver wcove_gpio_driver = {
> .driver = {
> .name = DRV_NAME,
> },
>
> and
>
> MODULE_ALIAS("platform:" DRV_NAME);
>
> You are suggesting to replace DRV_NAME with bxt_wcove_gpio(but why?)
> or something else?
Do instead this:
.driver = {
.name ="bxt_wcove_gpio",
},
and
MODULE_ALIAS("platform:bxt_wcove_gpio");
prev parent reply other threads:[~2016-06-20 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 21:22 [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver Bin Gao
2016-06-17 9:03 ` Mika Westerberg
2016-06-20 3:54 ` Bin Gao
2016-06-20 7:37 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620073724.GS1739@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=ajay.thomas.david.rajamanickam@intel.com \
--cc=bin.gao@intel.com \
--cc=bin.gao@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=yegnesh.s.iyer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.