From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 20 Jun 2016 10:00:46 +0100 Subject: [PATCH v2 4/5] mfd: rn5t618: register power off callback optionally In-Reply-To: <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> References: <20160608010429.19618-1-stefan@agner.ch> <20160608010429.19618-5-stefan@agner.ch> <20160616145907.GD4948@dell> <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> Message-ID: <20160620090046.GC1465@dell> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Sat, 18 Jun 2016, Stefan Agner wrote: > On 2016-06-16 07:59, Lee Jones wrote: > > On Tue, 07 Jun 2016, Stefan Agner wrote: > > > >> Only register power off if the PMIC is defined as system power > >> controller (see Documentation/devicetree/bindings/power/ > >> power-controller.txt). > >> > >> Reviewed-by: Marcel Ziswiler > >> Signed-off-by: Stefan Agner > > > > These should be chronological. > > > > Has been discussed already here: > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/345835.html > > It's an artifact of my development process, I keep the commits in my > local branches without signed off lines and add them before sending out > patches. So whenever I prepare a new revision, collected acks, sobs are > chronological, but end up before my sob. > > But since you are the second maintainer which has objection to that > style I probably should change that... It would make your life easier in the long run. :) > >> --- > >> drivers/mfd/rn5t618.c | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c > >> index 7607ced..d9b4d40 100644 > >> --- a/drivers/mfd/rn5t618.c > >> +++ b/drivers/mfd/rn5t618.c > >> @@ -103,9 +103,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c, > >> return ret; > >> } > >> > >> - if (!pm_power_off) { > >> - rn5t618_pm_power_off = priv; > >> - pm_power_off = rn5t618_power_off; > >> + if (of_device_is_system_power_controller(i2c->dev.of_node)) { > >> + if (!pm_power_off) { > >> + rn5t618_pm_power_off = priv; > >> + pm_power_off = rn5t618_power_off; > >> + } else { > >> + dev_err(&i2c->dev, "Failed to set poweroff capability, already defined\n"); > > > > This is not an error. Please use dev_warn() instead. > > > > Hm, I agree... FWIW, I copied the code (and that message) from here, > where dev_err is probably also not appropriate: > drivers/regulator/act8865-regulator.c Mark (Regulator maintainer) also accepts patches. > > Also, is this message actually accurate? Your commit message would > > indicate that it's not. > > Hm, maybe we should bail out with an error in that case since DT > explicitly asks to be power controller... Is that what you mean? I think I misunderstood the message. To fix this I would reword it. "Poweroff call-back already defined" -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 20 Jun 2016 10:00:46 +0100 Subject: [PATCH v2 4/5] mfd: rn5t618: register power off callback optionally In-Reply-To: <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> References: <20160608010429.19618-1-stefan@agner.ch> <20160608010429.19618-5-stefan@agner.ch> <20160616145907.GD4948@dell> <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> Message-ID: <20160620090046.GC1465@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 18 Jun 2016, Stefan Agner wrote: > On 2016-06-16 07:59, Lee Jones wrote: > > On Tue, 07 Jun 2016, Stefan Agner wrote: > > > >> Only register power off if the PMIC is defined as system power > >> controller (see Documentation/devicetree/bindings/power/ > >> power-controller.txt). > >> > >> Reviewed-by: Marcel Ziswiler > >> Signed-off-by: Stefan Agner > > > > These should be chronological. > > > > Has been discussed already here: > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/345835.html > > It's an artifact of my development process, I keep the commits in my > local branches without signed off lines and add them before sending out > patches. So whenever I prepare a new revision, collected acks, sobs are > chronological, but end up before my sob. > > But since you are the second maintainer which has objection to that > style I probably should change that... It would make your life easier in the long run. :) > >> --- > >> drivers/mfd/rn5t618.c | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c > >> index 7607ced..d9b4d40 100644 > >> --- a/drivers/mfd/rn5t618.c > >> +++ b/drivers/mfd/rn5t618.c > >> @@ -103,9 +103,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c, > >> return ret; > >> } > >> > >> - if (!pm_power_off) { > >> - rn5t618_pm_power_off = priv; > >> - pm_power_off = rn5t618_power_off; > >> + if (of_device_is_system_power_controller(i2c->dev.of_node)) { > >> + if (!pm_power_off) { > >> + rn5t618_pm_power_off = priv; > >> + pm_power_off = rn5t618_power_off; > >> + } else { > >> + dev_err(&i2c->dev, "Failed to set poweroff capability, already defined\n"); > > > > This is not an error. Please use dev_warn() instead. > > > > Hm, I agree... FWIW, I copied the code (and that message) from here, > where dev_err is probably also not appropriate: > drivers/regulator/act8865-regulator.c Mark (Regulator maintainer) also accepts patches. > > Also, is this message actually accurate? Your commit message would > > indicate that it's not. > > Hm, maybe we should bail out with an error in that case since DT > explicitly asks to be power controller... Is that what you mean? I think I misunderstood the message. To fix this I would reword it. "Poweroff call-back already defined" -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 4/5] mfd: rn5t618: register power off callback optionally Date: Mon, 20 Jun 2016 10:00:46 +0100 Message-ID: <20160620090046.GC1465@dell> References: <20160608010429.19618-1-stefan@agner.ch> <20160608010429.19618-5-stefan@agner.ch> <20160616145907.GD4948@dell> <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Stefan Agner Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, max.oss.09@gmail.com, khilman@baylibre.com, ijc+devicetree@hellion.org.uk, lgirdwood@gmail.com, robh+dt@kernel.org, linux@armlinux.org.uk, b.galvani@gmail.com, broonie@kernel.org, marcel@ziswiler.com, galak@codeaurora.org, carlo@caione.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gU2F0LCAxOCBKdW4gMjAxNiwgU3RlZmFuIEFnbmVyIHdyb3RlOgoKPiBPbiAyMDE2LTA2LTE2 IDA3OjU5LCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBPbiBUdWUsIDA3IEp1biAyMDE2LCBTdGVmYW4g QWduZXIgd3JvdGU6Cj4gPiAKPiA+PiBPbmx5IHJlZ2lzdGVyIHBvd2VyIG9mZiBpZiB0aGUgUE1J QyBpcyBkZWZpbmVkIGFzIHN5c3RlbSBwb3dlcgo+ID4+IGNvbnRyb2xsZXIgKHNlZSBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXIvCj4gPj4gcG93ZXItY29udHJvbGxlci50 eHQpLgo+ID4+Cj4gPj4gUmV2aWV3ZWQtYnk6IE1hcmNlbCBaaXN3aWxlciA8bWFyY2VsLnppc3dp bGVyQHRvcmFkZXguY29tPgo+ID4+IFNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBBZ25lciA8c3RlZmFu QGFnbmVyLmNoPgo+ID4gCj4gPiBUaGVzZSBzaG91bGQgYmUgY2hyb25vbG9naWNhbC4KPiA+IAo+ IAo+IEhhcyBiZWVuIGRpc2N1c3NlZCBhbHJlYWR5IGhlcmU6Cj4gaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvcGlwZXJtYWlsL2xpbnV4LWFybS1rZXJuZWwvMjAxNS1NYXkvMzQ1ODM1Lmh0bWwK PiAKPiBJdCdzIGFuIGFydGlmYWN0IG9mIG15IGRldmVsb3BtZW50IHByb2Nlc3MsIEkga2VlcCB0 aGUgY29tbWl0cyBpbiBteQo+IGxvY2FsIGJyYW5jaGVzIHdpdGhvdXQgc2lnbmVkIG9mZiBsaW5l cyBhbmQgYWRkIHRoZW0gYmVmb3JlIHNlbmRpbmcgb3V0Cj4gcGF0Y2hlcy4gU28gd2hlbmV2ZXIg SSBwcmVwYXJlIGEgbmV3IHJldmlzaW9uLCBjb2xsZWN0ZWQgYWNrcywgc29icyBhcmUKPiBjaHJv bm9sb2dpY2FsLCBidXQgZW5kIHVwIGJlZm9yZSBteSBzb2IuCj4gCj4gQnV0IHNpbmNlIHlvdSBh cmUgdGhlIHNlY29uZCBtYWludGFpbmVyIHdoaWNoIGhhcyBvYmplY3Rpb24gdG8gdGhhdAo+IHN0 eWxlIEkgcHJvYmFibHkgc2hvdWxkIGNoYW5nZSB0aGF0Li4uCgpJdCB3b3VsZCBtYWtlIHlvdXIg bGlmZSBlYXNpZXIgaW4gdGhlIGxvbmcgcnVuLiA6KQoKPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9t ZmQvcm41dDYxOC5jIHwgMTAgKysrKysrKy0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv bWZkL3JuNXQ2MTguYyBiL2RyaXZlcnMvbWZkL3JuNXQ2MTguYwo+ID4+IGluZGV4IDc2MDdjZWQu LmQ5YjRkNDAgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9tZmQvcm41dDYxOC5jCj4gPj4gKysr IGIvZHJpdmVycy9tZmQvcm41dDYxOC5jCj4gPj4gQEAgLTEwMyw5ICsxMDMsMTMgQEAgc3RhdGlj IGludCBybjV0NjE4X2kyY19wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqaTJjLAo+ID4+ICAJCXJl dHVybiByZXQ7Cj4gPj4gIAl9Cj4gPj4KPiA+PiAtCWlmICghcG1fcG93ZXJfb2ZmKSB7Cj4gPj4g LQkJcm41dDYxOF9wbV9wb3dlcl9vZmYgPSBwcml2Owo+ID4+IC0JCXBtX3Bvd2VyX29mZiA9IHJu NXQ2MThfcG93ZXJfb2ZmOwo+ID4+ICsJaWYgKG9mX2RldmljZV9pc19zeXN0ZW1fcG93ZXJfY29u dHJvbGxlcihpMmMtPmRldi5vZl9ub2RlKSkgewo+ID4+ICsJCWlmICghcG1fcG93ZXJfb2ZmKSB7 Cj4gPj4gKwkJCXJuNXQ2MThfcG1fcG93ZXJfb2ZmID0gcHJpdjsKPiA+PiArCQkJcG1fcG93ZXJf b2ZmID0gcm41dDYxOF9wb3dlcl9vZmY7Cj4gPj4gKwkJfSBlbHNlIHsKPiA+PiArCQkJZGV2X2Vy cigmaTJjLT5kZXYsICJGYWlsZWQgdG8gc2V0IHBvd2Vyb2ZmIGNhcGFiaWxpdHksIGFscmVhZHkg ZGVmaW5lZFxuIik7Cj4gPiAKPiA+IFRoaXMgaXMgbm90IGFuIGVycm9yLiAgUGxlYXNlIHVzZSBk ZXZfd2FybigpIGluc3RlYWQuCj4gPiAKPiAKPiBIbSwgSSBhZ3JlZS4uLiBGV0lXLCBJIGNvcGll ZCB0aGUgY29kZSAoYW5kIHRoYXQgbWVzc2FnZSkgZnJvbSBoZXJlLAo+IHdoZXJlIGRldl9lcnIg aXMgcHJvYmFibHkgYWxzbyBub3QgYXBwcm9wcmlhdGU6Cj4gZHJpdmVycy9yZWd1bGF0b3IvYWN0 ODg2NS1yZWd1bGF0b3IuYwoKTWFyayAoUmVndWxhdG9yIG1haW50YWluZXIpIGFsc28gYWNjZXB0 cyBwYXRjaGVzLgoKPiA+IEFsc28sIGlzIHRoaXMgbWVzc2FnZSBhY3R1YWxseSBhY2N1cmF0ZT8g IFlvdXIgY29tbWl0IG1lc3NhZ2Ugd291bGQKPiA+IGluZGljYXRlIHRoYXQgaXQncyBub3QuCj4g Cj4gSG0sIG1heWJlIHdlIHNob3VsZCBiYWlsIG91dCB3aXRoIGFuIGVycm9yIGluIHRoYXQgY2Fz ZSBzaW5jZSBEVAo+IGV4cGxpY2l0bHkgYXNrcyB0byBiZSBwb3dlciBjb250cm9sbGVyLi4uIElz IHRoYXQgd2hhdCB5b3UgbWVhbj8KCkkgdGhpbmsgSSBtaXN1bmRlcnN0b29kIHRoZSBtZXNzYWdl LiAgVG8gZml4IHRoaXMgSSB3b3VsZCByZXdvcmQgaXQuCgoiUG93ZXJvZmYgY2FsbC1iYWNrIGFs cmVhZHkgZGVmaW5lZCIKCi0tIApMZWUgSm9uZXMKTGluYXJvIFNUTWljcm9lbGVjdHJvbmljcyBM YW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753851AbcFTJCD (ORCPT ); Mon, 20 Jun 2016 05:02:03 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36999 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbcFTJAd (ORCPT ); Mon, 20 Jun 2016 05:00:33 -0400 Date: Mon, 20 Jun 2016 10:00:46 +0100 From: Lee Jones To: Stefan Agner Cc: lgirdwood@gmail.com, broonie@kernel.org, khilman@baylibre.com, carlo@caione.org, b.galvani@gmail.com, max.oss.09@gmail.com, marcel@ziswiler.com, linux@armlinux.org.uk, galak@codeaurora.org, ijc+devicetree@hellion.org.uk, mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH v2 4/5] mfd: rn5t618: register power off callback optionally Message-ID: <20160620090046.GC1465@dell> References: <20160608010429.19618-1-stefan@agner.ch> <20160608010429.19618-5-stefan@agner.ch> <20160616145907.GD4948@dell> <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <876c6fc0a1e300e95eda616c8c71a3ec@agner.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Jun 2016, Stefan Agner wrote: > On 2016-06-16 07:59, Lee Jones wrote: > > On Tue, 07 Jun 2016, Stefan Agner wrote: > > > >> Only register power off if the PMIC is defined as system power > >> controller (see Documentation/devicetree/bindings/power/ > >> power-controller.txt). > >> > >> Reviewed-by: Marcel Ziswiler > >> Signed-off-by: Stefan Agner > > > > These should be chronological. > > > > Has been discussed already here: > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/345835.html > > It's an artifact of my development process, I keep the commits in my > local branches without signed off lines and add them before sending out > patches. So whenever I prepare a new revision, collected acks, sobs are > chronological, but end up before my sob. > > But since you are the second maintainer which has objection to that > style I probably should change that... It would make your life easier in the long run. :) > >> --- > >> drivers/mfd/rn5t618.c | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > >> > >> diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c > >> index 7607ced..d9b4d40 100644 > >> --- a/drivers/mfd/rn5t618.c > >> +++ b/drivers/mfd/rn5t618.c > >> @@ -103,9 +103,13 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c, > >> return ret; > >> } > >> > >> - if (!pm_power_off) { > >> - rn5t618_pm_power_off = priv; > >> - pm_power_off = rn5t618_power_off; > >> + if (of_device_is_system_power_controller(i2c->dev.of_node)) { > >> + if (!pm_power_off) { > >> + rn5t618_pm_power_off = priv; > >> + pm_power_off = rn5t618_power_off; > >> + } else { > >> + dev_err(&i2c->dev, "Failed to set poweroff capability, already defined\n"); > > > > This is not an error. Please use dev_warn() instead. > > > > Hm, I agree... FWIW, I copied the code (and that message) from here, > where dev_err is probably also not appropriate: > drivers/regulator/act8865-regulator.c Mark (Regulator maintainer) also accepts patches. > > Also, is this message actually accurate? Your commit message would > > indicate that it's not. > > Hm, maybe we should bail out with an error in that case since DT > explicitly asks to be power controller... Is that what you mean? I think I misunderstood the message. To fix this I would reword it. "Poweroff call-back already defined" -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog