Re: [PATCH] mlx: fix compilation with older Glibc

[Adrien Mazarguil <adrien.mazarguil@6wind.com>]

On Fri, Jun 17, 2016 at 05:29:53PM +0100, Ferruh Yigit wrote:
> On 6/14/2016 10:22 AM, Adrien Mazarguil wrote:
> > A missing define in the previous patch causes additional compilation
> > issues.
> > 
> > Fixes: 3025206f5060 ("mlx: fix compilation with recent Glibc")
> > 
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> "older Glibc" or "recent Glibc" can be very hard to trace from git
> history later.

I wasn't sure about the exact version, it appears to be 2.19 and/or 2.20,
where _BSD_SOURCE was modified and subsequently removed.

I suggest squashing this patch into the original broken commit ("mlx: fix
compilation with recent Glibc") if possible, I did not submit a v2 as it is
already applied on dpdk-next-net.

> Does it make sense to add glibc version info for the failing ones or
> fixed one?

Depends if we can modify the first commit. If we do, let's squash them
together before adding version information, otherwise let's modify the
second one only.

I can submit a v2 that overrides both commits or only the second one, tell
me what you think is best.

-- 
Adrien Mazarguil
6WIND