From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dennis Chen <barracks510@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: multitouch: add support for Type Cover Pro 3
Date: Mon, 20 Jun 2016 11:59:34 +0200 [thread overview]
Message-ID: <20160620095934.GN24234@mail.corp.redhat.com> (raw)
In-Reply-To: <1466369282.15726.7.camel@gmail.com>
On Jun 19 2016 or thereabouts, Dennis Chen wrote:
> On Sat, 2016-06-18 at 21:45 +0200, Benjamin Tissoires wrote:
> >
> > That's the entire purpose of the series I mentioned below. It adds
> > the keyboard support, caps lock and multitouch, so there is nothing
> > more to fix once it is in. The benefit is that
> > MT_CLS_EXPORT_ALL_INPUTS exports far too many input devices while
> > the series exports only the required ones.
> >
>
> Ah. Sorry, I misunderstood.
no worries.
>
> I've tested the patches you sent. There is one major issue: the
> keyboard/touchpad no longer functions after a disconnect. However, on a
> clean bootup of the Surface Pro 3, I can confirm that the keyboard
> seems fully functional, i.e. touchpad works, CAPS LOCK LED is toggled,
> etc.
When you say disconnect, you mean disconnecting the cover and
re-attaching it?
If so, I can't understand why it would fail with my patches but
not without. Could you send the dmesg after disconnet/reconnect
and some hid-recorder[1] trace after re-attaching the device when
the keyboard is not working?
Cheers,
Benjamin
[1] http://bentiss.github.io/hid-replay-docs/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-20 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 20:47 [PATCH] HID: multitouch: add support for Type Cover Pro 3 Dennis Chen
2016-06-17 21:00 ` Jiri Kosina
2016-06-17 21:11 ` Benjamin Tissoires
2016-06-18 18:53 ` Dennis Chen
2016-06-18 19:45 ` Benjamin Tissoires
2016-06-18 23:13 ` Dennis Chen
2016-06-19 20:48 ` Dennis Chen
2016-06-20 9:59 ` Benjamin Tissoires [this message]
2016-06-24 3:38 ` Dennis Chen
2016-06-24 7:14 ` Benjamin Tissoires
2016-06-25 7:49 ` Dennis Chen
2016-07-01 14:52 ` Benjamin Tissoires
2016-07-23 20:13 ` Dennis Chen
2016-07-25 10:16 ` Benjamin Tissoires
2016-09-19 16:30 ` Dennis Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620095934.GN24234@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=barracks510@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.