From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Hsu <KCHSU0@nuvoton.com>
Cc: YHCHuang@nuvoton.com,
AP MS30 Linux ALSA <alsa-devel@alsa-project.org>,
broonie@kernel.org, CTLIN0@nuvoton.com, lgirdwood@gmail.com
Subject: Re: ASoC: nau8825: cross talk suppression measurement function
Date: Mon, 20 Jun 2016 13:00:12 +0300 [thread overview]
Message-ID: <20160620100012.GK32247@mwanda> (raw)
In-Reply-To: <57674C20.3080707@nuvoton.com>
On Mon, Jun 20, 2016 at 09:51:28AM +0800, John Hsu wrote:
> Is it better to separate this function to two case, one locked with
> timeout and the other not? Do you have any suggestion about it?
> Thank you.
It should return the error code and the callers should handle it. We
always have to know if we have the lock or not.
regards,
dan carpenter
next prev parent reply other threads:[~2016-06-20 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 12:33 ASoC: nau8825: cross talk suppression measurement function Dan Carpenter
2016-06-20 1:51 ` John Hsu
2016-06-20 10:00 ` Dan Carpenter [this message]
2016-06-22 3:09 ` John Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620100012.GK32247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.