From: Carlos Maiolino <cmaiolino@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_copy: fix minor sparse endian nit
Date: Mon, 20 Jun 2016 12:41:50 +0200 [thread overview]
Message-ID: <20160620104150.GA28212@redhat.com> (raw)
In-Reply-To: <a51bba5e-01ba-d73b-6fe6-ac3a411c7283@redhat.com>
On Fri, Jun 17, 2016 at 11:44:44AM -0500, Eric Sandeen wrote:
> The intermediate variable should not have been endian-annotated;
> it is the local cpu representation not the on-disk representation.
>
Looks good, you can add:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
> index 2119a0b..1bc5163 100644
> --- a/copy/xfs_copy.c
> +++ b/copy/xfs_copy.c
> @@ -506,7 +506,7 @@ sb_update_uuid(
> */
> if (!uuid_equal(&tcarg->uuid, &ag_hdr->xfs_sb->sb_uuid) &&
> xfs_sb_version_hascrc(sb) && !xfs_sb_version_hasmetauuid(sb)) {
> - __be32 feat;
> + __uint32_t feat;
>
> feat = be32_to_cpu(ag_hdr->xfs_sb->sb_features_incompat);
> feat |= XFS_SB_FEAT_INCOMPAT_META_UUID;
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-06-20 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 16:44 [PATCH] xfs_copy: fix minor sparse endian nit Eric Sandeen
2016-06-20 10:41 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620104150.GA28212@redhat.com \
--to=cmaiolino@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.