From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com
Subject: Re: [PATCH] virtio: fix crash on querying xstats
Date: Mon, 20 Jun 2016 19:47:25 +0800 [thread overview]
Message-ID: <20160620114725.GI23111@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <f86c0f35-aa58-4674-f088-621399930a21@intel.com>
On Mon, Jun 20, 2016 at 12:02:16PM +0100, Remy Horton wrote:
>
> On 20/06/2016 11:50, Yuanhan Liu wrote:
> >Trying to access xstats_names after "if (stats_names == NULL)" is
> >obviously wrong, which would result to a crash while running "show
> >port xstats 0" in testpmd with virtio PMD.
> >
> >The fix is also straightforward: just revese the check.
> >
> >Fixes: baf91c395b18 ("net/virtio: fetch extended statistics with integer ids")
> >
> >Cc: Remy Horton <remy.horton@intel.com>
> >Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Acked-by: Remy Horton <remy.horton@intel.com>
Applied to dpdk-next-virtio.
--yliu
prev parent reply other threads:[~2016-06-20 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 10:50 [PATCH] virtio: fix crash on querying xstats Yuanhan Liu
2016-06-20 11:02 ` Remy Horton
2016-06-20 11:47 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620114725.GI23111@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.