Re: [libvirt] gnulib and 32-bit libvirt build, rpl_canonicalize_file_name

["Ján Tomko" <jtomko@redhat.com>]

On Mon, Jun 20, 2016 at 12:37:23PM +0100, Ian Jackson wrote:
>The Xen Project's automated test (CI) system has reported a build
>failure in libvirt; libvirt uses gnulib.  osstest has bisected it to a
>specific gnulib commit.  (Email from osstest is quoted below.)
>
>The error message is:
>
>  ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function
>  `rpl_canonicalize_file_name':
>
>  /home/osstest/build.95966.build-i386-libvirt/libvirt/gnulib/lib/canonicalize-lgpl.c:400: multiple definition of `rpl_canonicalize_file_name'
>
>  .libs/virpcimock_la-virpcimock.o:/home/osstest/build.95966.build-i386-libvirt/libvirt/tests/virpcimock.c:954: first defined here
>
>  collect2: error: ld returned 1 exit status
>
>Do you already know about this ?  Would you like us to submit a
>patch to gnulib ?
>
>Thanks,
>Ian.
>
>
>osstest service owner writes ("[qemu-upstream-4.3-testing bisection] complete build-i386-libvirt"):
>> branch xen-4.3-testing
>> xenbranch xen-4.3-testing
>> job build-i386-libvirt
>> testid libvirt-build
>>
>> Tree: libvirt git://xenbits.xen.org/libvirt.git
>> Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git
>> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
>> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
>> Tree: xen git://xenbits.xen.org/xen.git
>>
>> *** Found and reproduced problem changeset ***
>>
>>   Bug is in tree:  libvirt_gnulib git://git.sv.gnu.org/gnulib.git
>>   Bug introduced:  54615b95ff238e235e806855efc46a9abad09f2e
>>   Bug not present: e78f894d0bdc770101bc040613f4ea94e45f38f7
>>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/95966/
>>
>>
>>   commit 54615b95ff238e235e806855efc46a9abad09f2e
>>   Author: Paul Eggert <eggert@cs.ucla.edu>
>>   Date:   Sat Feb 6 18:11:48 2016 -0800
>>
>>       misc: port better to gcc -fsanitize=address
>>
>>       Without these patches, ./configure CFLAGS='-fsanitize=address'
>>       would compute incorrect values.  This patch fixes some (but not all)
>>       test failures with recent glibc, with this configuration.

This has been fixed in gnulib already:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=246b3b2
commit 246b3b28808ee5f4664be674dce573af9497fc7a
Author:     Eric Blake <eblake@redhat.com>
CommitDate: 2016-05-27 14:04:35 -0600

    canonicalize: Fix broken probe for realpath.

Pulled into libvirt by:
commit 0ebd0b19d377775b93eeea9d49318d7a69e147da
Author:     Eric Blake <eblake@redhat.com>
CommitDate: 2016-05-27 14:06:45 -0600

    maint: update to latest gnulib
    
    Fix a regression in checking for realpath (which caused link
    failures regarding duplicate rpl_canonicalize_file_name), and
    fix the mingw build regarding unsetenv.
    
    * .gnulib: Update to latest.
    
    Signed-off-by: Eric Blake <eblake@redhat.com>

git describe: v1.3.5-rc1 contains: v1.3.5-rc1^0


The osstest service seems to be building libvirt commit:
commit 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7
Author:     John Ferlan <jferlan@redhat.com>

    logical: Clean up allocation when building regex on the fly

git describe: v1.3.1-92-g6ec319b contains: v1.3.2-rc1~262

which used gnulib from before the commit that broke it.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel