All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, johan@kernel.org,
	bth@kamstrup.dk
Subject: Re: Micrel Phy KSZ8031 clock select setting in dts
Date: Mon, 20 Jun 2016 15:12:45 +0200	[thread overview]
Message-ID: <20160620131245.GS9677@pengutronix.de> (raw)
In-Reply-To: <8917af7a-82b1-5304-0c35-0efa1f598ba7@cogentembedded.com>

On Mon, Jun 20, 2016 at 03:56:10PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 6/20/2016 3:08 PM, Oliver Graute wrote:
> 
> >thx you both for confirming that. Can you tell me also if the clock
> >statement s fine in my dts?
> >
> >&fec1 {
> >	pinctrl-names = "default";
> >	pinctrl-0 = <&pinctrl_enet1>;
> >	phy-mode = "rmii";
> >	micrel,rmii-reference-clock-select-25-mhz;
> >	clocks,rmii-ref;
> 
>    You need:
> 
> 	clocks = <&your_clock>;
> 	clock-names = "rmii-ref";

With a clock node specified like:

	your_clock: rmii-ref {
		#clock-cells = <0>;
		compatible = "fixed-clock";
		clock-frequency = <50000000>;
	};

(assuming this is a fixed clock which can't be retrieved from elsewhere
in the clock tree)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2016-06-20 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 13:04 Micrel Phy KSZ8031 clock select setting in dts Oliver Graute
2016-06-17 13:48 ` Sergei Shtylyov
2016-06-19 19:29   ` Oliver Graute
2016-06-20  6:21     ` Sascha Hauer
2016-06-20 12:08       ` Oliver Graute
2016-06-20 12:45         ` Andrew Lunn
2016-06-20 17:14           ` Oliver Graute
2016-06-21  6:16             ` Sascha Hauer
2016-06-22  8:18               ` Oliver Graute
2016-06-20 12:56         ` Sergei Shtylyov
2016-06-20 13:12           ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620131245.GS9677@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=bth@kamstrup.dk \
    --cc=f.fainelli@gmail.com \
    --cc=johan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.