From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: andrew zamansky
<andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
azamansk-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org,
Dan.Morav-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org,
stimpy1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 4/4 v3] add tpm2 capability test flag to tpm_tis driver
Date: Mon, 20 Jun 2016 17:38:57 +0300 [thread overview]
Message-ID: <20160620143857.GB8712@intel.com> (raw)
In-Reply-To: <1466417229-16734-5-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
Isn't tpm2_probe() call now twice in tpm_tis initialization?
On Mon, Jun 20, 2016 at 01:07:09PM +0300, andrew zamansky wrote:
> Signed-off-by: Andrew Azmansky <andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 30aff5b..859fb8c 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -524,7 +524,7 @@ static bool tpm_tis_req_canceled(struct tpm_chip *chip, u8 status)
> }
>
> static const struct tpm_class_ops tpm_tis = {
> - .flags = TPM_OPS_AUTO_STARTUP,
> + .flags = TPM_OPS_AUTO_STARTUP | TPM_OPS_PROBE_TPM2,
> .status = tpm_tis_status,
> .recv = tpm_tis_recv,
> .send = tpm_tis_send,
> --
> 1.9.1
>
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://sdm.link/zohomanageengine
next prev parent reply other threads:[~2016-06-20 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 10:07 [PATCH 0/4 v2] Add TPM 2.0 support to the Nuvoton i2c driver andrew zamansky
[not found] ` <1466417229-16734-1-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
2016-06-20 10:07 ` [PATCH 1/4 v2] tpm: Factor out common startup code andrew zamansky
2016-06-20 10:07 ` [PATCH 2/4 v2] tpm: Add TPM 2.0 support to the Nuvoton i2c driver (NPCT6xx family) andrew zamansky
2016-06-20 10:07 ` [PATCH 3/4 v2] move tpm auto startup functions andrew zamansky
[not found] ` <1466417229-16734-4-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
2016-06-20 14:38 ` Jarkko Sakkinen
2016-06-20 10:07 ` [PATCH 4/4 v3] add tpm2 capability test flag to tpm_tis driver andrew zamansky
[not found] ` <1466417229-16734-5-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
2016-06-20 14:38 ` Jarkko Sakkinen [this message]
[not found] ` <20160620143857.GB8712-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-20 21:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620143857.GB8712@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=Dan.Morav-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org \
--cc=andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org \
--cc=azamansk-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=stimpy1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.