From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rYKp72qNHzDqCr for ; Tue, 21 Jun 2016 04:56:31 +1000 (AEST) Date: Mon, 20 Jun 2016 15:56:21 -0300 From: Thadeu Lima de Souza Cascardo To: "Naveen N. Rao" Cc: Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, Matt Evans , Daniel Borkmann , Alexei Starovoitov , Denis Kirjanov , Paul Mackerras , "David S. Miller" , Ananth N Mavinakayanahalli Subject: Re: [PATCH] ppc: Fix BPF JIT for ABIv2 Message-ID: <20160620185620.GD3516@indiana.gru.redhat.com> References: <908d3552b5eb240b28f70aee7c4c86e2b600aa02.1465304785.git.naveen.n.rao@linux.vnet.ibm.com> <3rWKtT2tSrz9t2G@ozlabs.org> <20160617130042.GO3516@indiana.gru.redhat.com> <20160619174914.GC8886@naverao1-tp.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160619174914.GC8886@naverao1-tp.localdomain> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Jun 19, 2016 at 11:19:14PM +0530, Naveen N. Rao wrote: > On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > > On Fri, Jun 17, 2016 at 10:53:21PM +1000, Michael Ellerman wrote: > > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c b/arch/powerpc/net/bpf_jit_comp64.c > > > > new file mode 100644 > > > > index 0000000..954ff53 > > > > --- /dev/null > > > > +++ b/arch/powerpc/net/bpf_jit_comp64.c > > > > @@ -0,0 +1,956 @@ > > > ... > > > > + > > > > +static void bpf_jit_fill_ill_insns(void *area, unsigned int size) > > > > +{ > > > > + int *p = area; > > > > + > > > > + /* Fill whole space with trap instructions */ > > > > + while (p < (int *)((char *)area + size)) > > > > + *p++ = BREAKPOINT_INSTRUCTION; > > > > +} > > > > > > This breaks the build for some configs, presumably you're missing a header: > > > > > > arch/powerpc/net/bpf_jit_comp64.c:30:10: error: 'BREAKPOINT_INSTRUCTION' undeclared (first use in this function) > > > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/12720611/ > > > > > > cheers > > > > Hi, Michael and Naveen. > > > > I noticed independently that there is a problem with BPF JIT and ABIv2, and > > worked out the patch below before I noticed Naveen's patchset and the latest > > changes in ppc tree for a better way to check for ABI versions. > > > > However, since the issue described below affect mainline and stable kernels, > > would you consider applying it before merging your two patchsets, so that we can > > more easily backport the fix? > > Hi Cascardo, > Given that this has been broken on ABIv2 since forever, I didn't bother > fixing it. But, I can see why this would be a good thing to have for > -stable and existing distros. However, while your patch below may fix > the crash you're seeing on ppc64le, it is not sufficient -- you'll need > changes in bpf_jit_asm.S as well. Hi, Naveen. Any tips on how to exercise possible issues there? Or what changes you think would be sufficient? I will see what I can find by myself, but would appreciate any help. Regards. Cascardo. > > Regards, > Naveen > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thadeu Lima de Souza Cascardo Subject: Re: [PATCH] ppc: Fix BPF JIT for ABIv2 Date: Mon, 20 Jun 2016 15:56:21 -0300 Message-ID: <20160620185620.GD3516@indiana.gru.redhat.com> References: <908d3552b5eb240b28f70aee7c4c86e2b600aa02.1465304785.git.naveen.n.rao@linux.vnet.ibm.com> <3rWKtT2tSrz9t2G@ozlabs.org> <20160617130042.GO3516@indiana.gru.redhat.com> <20160619174914.GC8886@naverao1-tp.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Matt Evans , Daniel Borkmann , Alexei Starovoitov , Denis Kirjanov , linux-kernel@vger.kernel.org, Paul Mackerras , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Ananth N Mavinakayanahalli To: "Naveen N. Rao" Return-path: Content-Disposition: inline In-Reply-To: <20160619174914.GC8886@naverao1-tp.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: netdev.vger.kernel.org T24gU3VuLCBKdW4gMTksIDIwMTYgYXQgMTE6MTk6MTRQTSArMDUzMCwgTmF2ZWVuIE4uIFJhbyB3 cm90ZToKPiBPbiAyMDE2LzA2LzE3IDEwOjAwQU0sIFRoYWRldSBMaW1hIGRlIFNvdXphIENhc2Nh cmRvIHdyb3RlOgo+ID4gT24gRnJpLCBKdW4gMTcsIDIwMTYgYXQgMTA6NTM6MjFQTSArMTAwMCwg TWljaGFlbCBFbGxlcm1hbiB3cm90ZToKPiA+ID4gT24gVHVlLCAyMDE2LTA3LTA2IGF0IDEzOjMy OjIzIFVUQywgIk5hdmVlbiBOLiBSYW8iIHdyb3RlOgo+ID4gPiA+IGRpZmYgLS1naXQgYS9hcmNo L3Bvd2VycGMvbmV0L2JwZl9qaXRfY29tcDY0LmMgYi9hcmNoL3Bvd2VycGMvbmV0L2JwZl9qaXRf Y29tcDY0LmMKPiA+ID4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gPiA+IGluZGV4IDAwMDAw MDAuLjk1NGZmNTMKPiA+ID4gPiAtLS0gL2Rldi9udWxsCj4gPiA+ID4gKysrIGIvYXJjaC9wb3dl cnBjL25ldC9icGZfaml0X2NvbXA2NC5jCj4gPiA+ID4gQEAgLTAsMCArMSw5NTYgQEAKPiA+ID4g Li4uCj4gPiA+ID4gKwo+ID4gPiA+ICtzdGF0aWMgdm9pZCBicGZfaml0X2ZpbGxfaWxsX2luc25z KHZvaWQgKmFyZWEsIHVuc2lnbmVkIGludCBzaXplKQo+ID4gPiA+ICt7Cj4gPiA+ID4gKwlpbnQg KnAgPSBhcmVhOwo+ID4gPiA+ICsKPiA+ID4gPiArCS8qIEZpbGwgd2hvbGUgc3BhY2Ugd2l0aCB0 cmFwIGluc3RydWN0aW9ucyAqLwo+ID4gPiA+ICsJd2hpbGUgKHAgPCAoaW50ICopKChjaGFyICop YXJlYSArIHNpemUpKQo+ID4gPiA+ICsJCSpwKysgPSBCUkVBS1BPSU5UX0lOU1RSVUNUSU9OOwo+ ID4gPiA+ICt9Cj4gPiA+IAo+ID4gPiBUaGlzIGJyZWFrcyB0aGUgYnVpbGQgZm9yIHNvbWUgY29u ZmlncywgcHJlc3VtYWJseSB5b3UncmUgbWlzc2luZyBhIGhlYWRlcjoKPiA+ID4gCj4gPiA+ICAg YXJjaC9wb3dlcnBjL25ldC9icGZfaml0X2NvbXA2NC5jOjMwOjEwOiBlcnJvcjogJ0JSRUFLUE9J TlRfSU5TVFJVQ1RJT04nIHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKQo+ ID4gPiAKPiA+ID4gaHR0cDovL2tpc3NrYi5lbGxlcm1hbi5pZC5hdS9raXNza2IvYnVpbGRyZXN1 bHQvMTI3MjA2MTEvCj4gPiA+IAo+ID4gPiBjaGVlcnMKPiA+IAo+ID4gSGksIE1pY2hhZWwgYW5k IE5hdmVlbi4KPiA+IAo+ID4gSSBub3RpY2VkIGluZGVwZW5kZW50bHkgdGhhdCB0aGVyZSBpcyBh IHByb2JsZW0gd2l0aCBCUEYgSklUIGFuZCBBQkl2MiwgYW5kCj4gPiB3b3JrZWQgb3V0IHRoZSBw YXRjaCBiZWxvdyBiZWZvcmUgSSBub3RpY2VkIE5hdmVlbidzIHBhdGNoc2V0IGFuZCB0aGUgbGF0 ZXN0Cj4gPiBjaGFuZ2VzIGluIHBwYyB0cmVlIGZvciBhIGJldHRlciB3YXkgdG8gY2hlY2sgZm9y IEFCSSB2ZXJzaW9ucy4KPiA+IAo+ID4gSG93ZXZlciwgc2luY2UgdGhlIGlzc3VlIGRlc2NyaWJl ZCBiZWxvdyBhZmZlY3QgbWFpbmxpbmUgYW5kIHN0YWJsZSBrZXJuZWxzLAo+ID4gd291bGQgeW91 IGNvbnNpZGVyIGFwcGx5aW5nIGl0IGJlZm9yZSBtZXJnaW5nIHlvdXIgdHdvIHBhdGNoc2V0cywg c28gdGhhdCB3ZSBjYW4KPiA+IG1vcmUgZWFzaWx5IGJhY2twb3J0IHRoZSBmaXg/Cj4gCj4gSGkg Q2FzY2FyZG8sCj4gR2l2ZW4gdGhhdCB0aGlzIGhhcyBiZWVuIGJyb2tlbiBvbiBBQkl2MiBzaW5j ZSBmb3JldmVyLCBJIGRpZG4ndCBib3RoZXIgCj4gZml4aW5nIGl0LiBCdXQsIEkgY2FuIHNlZSB3 aHkgdGhpcyB3b3VsZCBiZSBhIGdvb2QgdGhpbmcgdG8gaGF2ZSBmb3IgCj4gLXN0YWJsZSBhbmQg ZXhpc3RpbmcgZGlzdHJvcy4gSG93ZXZlciwgd2hpbGUgeW91ciBwYXRjaCBiZWxvdyBtYXkgZml4 IAo+IHRoZSBjcmFzaCB5b3UncmUgc2VlaW5nIG9uIHBwYzY0bGUsIGl0IGlzIG5vdCBzdWZmaWNp ZW50IC0tIHlvdSdsbCBuZWVkIAo+IGNoYW5nZXMgaW4gYnBmX2ppdF9hc20uUyBhcyB3ZWxsLgoK SGksIE5hdmVlbi4KCkFueSB0aXBzIG9uIGhvdyB0byBleGVyY2lzZSBwb3NzaWJsZSBpc3N1ZXMg dGhlcmU/IE9yIHdoYXQgY2hhbmdlcyB5b3UgdGhpbmsKd291bGQgYmUgc3VmZmljaWVudD8KCkkg d2lsbCBzZWUgd2hhdCBJIGNhbiBmaW5kIGJ5IG15c2VsZiwgYnV0IHdvdWxkIGFwcHJlY2lhdGUg YW55IGhlbHAuCgpSZWdhcmRzLgpDYXNjYXJkby4KCj4gCj4gUmVnYXJkcywKPiBOYXZlZW4KPiAK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMt ZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xp c3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2